add mobile specific text resizing (fixes #1) #2
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to address mobile layout overflow in the homepage hero text and navigation bar by introducing mobile screen-size detection and applying smaller typography on small screens. It also includes a significant repo packaging change by removing the repository-root workspace package.json / package-lock.json.
Changes:
- Add mobile detection via
react-responsiveand render smaller homepage hero typography on mobile. - Add a mobile-specific NavBar render path with smaller title/button typography.
- Remove the repository-root npm workspace manifests, leaving only the
green-day-websitepackage.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removed repo-root workspace manifest (workspace structure change). |
| package-lock.json | Removed repo-root lockfile (workspace structure change). |
| green-day-website/src/Pages/Home.jsx | Adds mobile detection and a mobile-specific render path with smaller hero text. |
| green-day-website/src/components/NavBar.jsx | Adds mobile detection and a mobile-specific NavBar layout with smaller typography. |
| green-day-website/package.json | Adds react-responsive dependency for mobile media queries. |
| green-day-website/package-lock.json | Updates lockfile for react-responsive and transitive deps. |
Files not reviewed (1)
- green-day-website/package-lock.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+14
to
+17
| if (isMobile) { | ||
| return ( | ||
| <Box sx={{ flexGrow: 1 }}> | ||
| <NavBar /> |
| marginTop: 2 | ||
| }} | ||
| > | ||
| <Typography variant="h5" component="h5" align="center" gutterBottom sx={{ marginTop: 4, color: '#FFFFFF', fontWeight: 'bold', textShadow: '2px 2px 4px rgba(0, 0, 0, 0.7)' }}> |
Comment on lines
+22
to
+26
| if (isMobile) { | ||
| return ( | ||
| <AppBar position="static" sx={{ backgroundColor: "#06402B" }}> | ||
| <Toolbar sx={{ px: { xs: 1.5, sm: 2.5 } }}> | ||
| <Box sx={{ display: 'flex', alignItems: 'center', flexGrow: 1 }}> |
Comment on lines
+42
to
+44
| <Typography variant="h6" component="div" sx={{ fontSize: '12px' }}> | ||
| Green Day LLC | ||
| </Typography> |
| "@mui/material": "^9.1.1", | ||
| "react": "^19.2.6", | ||
| "react-dom": "^19.2.6", | ||
| "react-responsive": "^10.0.1", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1
Fixes the issue where the navigation bar and homepage text would spill off into other page components or off the display.