Revert "add mobile specific text resizing (fixes #1) "#4
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reverts the previously introduced mobile-specific text resizing behavior by removing react-responsive-based conditional rendering, returning the UI to a single rendering path. In addition, it introduces repo-root npm workspace/lockfile artifacts that may be unrelated to the stated “revert” scope.
Changes:
- Removed
react-responsivedependency and alluseMediaQuery-driven mobile-only rendering branches in the Home page and NavBar. - Updated
green-day-websitelockfile to reflect dependency removal. - Added repo-root
package.json+package-lock.jsondefining an npm workspace that includesgreen-day-website.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Adds a repo-root npm workspace definition. |
| package-lock.json | Adds a repo-root lockfile for the new workspace. |
| green-day-website/src/Pages/Home.jsx | Removes mobile-specific branch and related dependency usage. |
| green-day-website/src/components/NavBar.jsx | Removes mobile-specific branch and related dependency usage. |
| green-day-website/package.json | Drops react-responsive dependency. |
| green-day-website/package-lock.json | Removes react-responsive (and transitive deps) from lockfile. |
Files not reviewed (1)
- green-day-website/package-lock.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+5
| { | ||
| "name": "greendayllc-workspace", | ||
| "private": true, | ||
| "workspaces": [ | ||
| "green-day-website" |
Comment on lines
1
to
6
| import { Typography, Box } from '@mui/material'; | ||
| import NavBar from '../components/NavBar'; | ||
| import PageHeader from '../components/PageHeader'; | ||
| import InfoBlock from '../components/InfoBlock'; | ||
| import { React } from 'react'; | ||
| import home from '../assets/home.jpg'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2