chore: migrate to Rust 2024#1224
Conversation
| pub unsafe fn unpack(val: usize) -> Self { | ||
| *Box::from_raw(val as *mut _) | ||
| unsafe { *Box::from_raw(val as *mut _) } |
There was a problem hiding this comment.
Hmm. Is this unsafe needed? It's already in an unsafe fn.
There was a problem hiding this comment.
Caught me by surprise too, although I understand now: https://doc.rust-lang.org/edition-guide/rust-2024/unsafe-op-in-unsafe-fn.html
| waveformatex_ptr, | ||
| Some(&mut closest_match), | ||
| ); | ||
| let hr = unsafe { |
There was a problem hiding this comment.
Pretty sure you're about to push the the change removing the unsafe from the fn but I'll tell you anyway.
simlay
left a comment
simlay
left a comment
There was a problem hiding this comment.
lgtm. Hope you don't mind the driveby review. I just felt like reading and this was simple enough. You were pushing changes about things I was commenting on so my comments might be out of date already.
Absolutely, thanks for reading along! |
roderickvd
force-pushed
the
chore/rust-2024
branch
2 times, most recently
from
c5296d3 to
26966eb
Compare
roderickvd
force-pushed
the
chore/rust-2024
branch
2 times, most recently
from
6cf3590 to
19463a3
Compare
roderickvd
force-pushed
the
chore/rust-2024
branch
from
19463a3 to
57a29fd
Compare
2 participants
No description provided.