ci: build UI bundle before Go in release + add PR ci workflow#2
Merged
Conversation
The release pipeline has been broken since 2026-04-22 (5 consecutive failed runs) because internal/serve/dist/ is gitignored and the workflow never built it before invoking go test / go build. //go:embed all:dist errors out when the directory is empty. release.yml: insert pnpm + Node setup and `make ui` between Set up Go and Run tests. The populated internal/serve/dist/ is now picked up by both the test step and the cross-compiled binary builds, and is naturally included in the air-gapped src tarball (existing tar excludes top-level dist/ only). ci.yml: new workflow gating PRs and non-main pushes on the same UI build + go build/vet/test + ui typecheck + vitest. Mirrors the release pipeline's prerequisites so a broken main is caught before merge. e2e and audit steps live in `make regression` for now — promotable to merge gates later. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| go-version-file: go.mod | ||
|
|
||
| - name: Set up pnpm | ||
| uses: pnpm/action-setup@v4 |
| go-version-file: go.mod | ||
|
|
||
| - name: Set up pnpm | ||
| uses: pnpm/action-setup@v4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR self-validates via the new ci.yml.
Test plan
Follow-ups (not in this PR)
🤖 Generated with Claude Code