ci: pass -tags sqlite_fts5 to go test and release binary builds#3
Merged
Conversation
mattn/go-sqlite3 only compiles FTS5 support when the sqlite_fts5 build tag is set. internal/serve/store's schema uses CREATE VIRTUAL TABLE … USING fts5(…) which fails at runtime with "no such module: fts5" without the tag. The release-on-main run that followed the UI-build fix (24950003140) made it past `make ui` and then blew up on ~25 store/serve tests with this error. Two release.yml steps were missing the tag: - "Run tests" → go test -tags sqlite_fts5 ./... - cross-compile loop → go build -trimpath -tags sqlite_fts5 … Side note: v0.1.0 / v0.1.1 binaries (last successful releases) were built without this tag, so they panic in OpenCostStore on first boot. Once this lands, the next release tag will be the first usable one since the FTS5 feature shipped. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fast-follow to PR #2. With UI build now in place, the post-merge release run made it past `make ui` and then failed with ~25 `schema DDL: no such module: fts5` errors in `internal/serve/store` and `internal/serve`.
`mattn/go-sqlite3` only compiles FTS5 support when the `sqlite_fts5` build tag is set. `internal/serve/store`'s schema uses `CREATE VIRTUAL TABLE … USING fts5(…)` — without the tag, `OpenCostStore()` fails at runtime.
Two `release.yml` steps were missing the tag:
Released-binary impact
v0.1.0 and v0.1.1 (last successful releases) were built without `-tags sqlite_fts5`. Those binaries panic at boot inside `OpenCostStore` — anyone who downloaded them and ran `ctm serve` would have hit it. Once this lands, the next tagged release is the first usable one since the FTS5 feature shipped.
Test plan
🤖 Generated with Claude Code