Skip to content

fix: allow critical drift reviews to finish #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Jul 11, 2026
Merged

fix: allow critical drift reviews to finish #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/reusable-drift-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ permissions:
jobs:
drift:
runs-on: ubuntu-latest
timeout-minutes: 15
# A critical drift can require up to three sequential primary reviews. Each
# service review has a 15-minute budget plus its polling grace period.
timeout-minutes: 60
env:
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
STRATEGY_DOMAIN: ${{ inputs.strategy_domain }}
Expand Down
1 change: 1 addition & 0 deletions tests/test_reusable_drift_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ def test_reusable_drift_workflow_enforces_lifecycle_preflight() -> None:
).read_text(encoding="utf-8")

assert "workflow_call:" in workflow
assert "timeout-minutes: 60" in workflow
assert "strategy_domain:" in workflow
assert "snapshot_repository:" in workflow
assert "snapshot_repository_token:" in workflow
Expand Down
Loading