fix: allow critical drift reviews to finish - #244
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
🤖 Codex PR Review✅ Merge allowed: No issues found Review by Codex PR Review bot • PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
A drift run with three critical strategies performs reviews serially. Each Codex service review has a 15-minute execution budget plus polling grace, but the reusable job itself timed out at 15 minutes and was cancelled before any degraded result or durable issue could be emitted.
Change
Raise the reusable drift job timeout to 60 minutes, covering the bounded sequential review budget while preserving the existing service-level timeout and degraded-issue handling.
Validation
PYTHONPATH=src python3 -m pytest -q tests/test_reusable_drift_workflow.pyactionlint .github/workflows/reusable-drift-check.ymlgit diff --check