Skip to content

[codex] reconcile cloud runtime drift #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Jul 6, 2026
Merged

[codex] reconcile cloud runtime drift #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 15 additions & 26 deletions .github/workflows/sync-cloud-run-env.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,6 +959,14 @@ jobs:
set -euo pipefail
python3 scripts/verify_cloud_run_strategy_plugin_mounts.py

- name: Reconcile Cloud Run traffic
if: steps.config.outputs.env_sync_enabled == 'true'
env:
SYNC_PLAN_JSON: ${{ steps.strategy_requirements.outputs.sync_plan_json }}
run: |
set -euo pipefail
python3 scripts/reconcile_cloud_runtime.py --platform longbridge --ensure-latest-traffic

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Pass expected commit only when deploy wait is enabled

This new reconciliation step always lets reconcile_cloud_runtime.py default --expected-commit to GITHUB_SHA, so supported env-only runs fail after syncing env when no image for the current commit was deployed. For example, the hk-verify dispatch path sets CLOUD_RUN_ENV_SYNC_WAIT_FOR_COMMIT=false when deploy_image is false, but this step still checks the latest ready revision’s commit-sha against the current workflow SHA and exits before scheduler sync; pass an empty expected commit or skip this step when the deploy/wait is intentionally disabled.

Useful? React with 👍 / 👎.


- name: Sync Cloud Scheduler schedule
if: steps.config.outputs.env_sync_enabled == 'true'
env:
Expand Down Expand Up @@ -1136,32 +1144,13 @@ jobs:
echo "Skipping shared LongBridge monitor dispatcher scheduler from ${DEPLOYMENT_LABEL}; owner is ${MONITOR_DISPATCHER_OWNER_LABEL:-SG}."
fi

legacy_jobs=(
"${CLOUD_RUN_SERVICE}-probe-scheduler"
"${CLOUD_RUN_SERVICE}-precheck-scheduler"
)
if [[ "${CLOUD_RUN_SERVICE}" == *-service ]]; then
legacy_jobs+=(
"${CLOUD_RUN_SERVICE%-service}-probe-scheduler"
"${CLOUD_RUN_SERVICE%-service}-precheck-scheduler"
)
fi
legacy_scope="${CLOUD_RUN_SERVICE#longbridge-quant-}"
legacy_scope="${legacy_scope%-service}"
if [ -n "${legacy_scope}" ] && [ "${legacy_scope}" != "${CLOUD_RUN_SERVICE}" ]; then
legacy_jobs+=("lb-${legacy_scope}-backup-execution")
fi
for legacy_job in "${legacy_jobs[@]}"; do
if gcloud scheduler jobs describe "${legacy_job}" \
--project="${GCP_PROJECT_ID}" \
--location="${scheduler_location}" >/dev/null 2>&1; then
echo "Deleting legacy Cloud Scheduler job ${legacy_job}; monitor dispatcher now owns probe/precheck."
gcloud scheduler jobs delete "${legacy_job}" \
--project="${GCP_PROJECT_ID}" \
--location="${scheduler_location}" \
--quiet
fi
done
- name: Reconcile legacy Cloud Scheduler jobs
if: steps.config.outputs.env_sync_enabled == 'true'
env:
SYNC_PLAN_JSON: ${{ steps.strategy_requirements.outputs.sync_plan_json }}
run: |
set -euo pipefail
python3 scripts/reconcile_cloud_runtime.py --platform longbridge --delete-legacy-schedulers

- name: Prune old Cloud Run revisions
if: steps.config.outputs.enabled == 'true'
Expand Down
Loading
Loading