[codex] reconcile cloud runtime drift - #302
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e97c542775
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| SYNC_PLAN_JSON: ${{ steps.strategy_requirements.outputs.sync_plan_json }} | ||
| run: | | ||
| set -euo pipefail | ||
| python3 scripts/reconcile_cloud_runtime.py --platform longbridge --ensure-latest-traffic |
There was a problem hiding this comment.
This new reconciliation step always lets reconcile_cloud_runtime.py default --expected-commit to GITHUB_SHA, so supported env-only runs fail after syncing env when no image for the current commit was deployed. For example, the hk-verify dispatch path sets CLOUD_RUN_ENV_SYNC_WAIT_FOR_COMMIT=false when deploy_image is false, but this step still checks the latest ready revision’s commit-sha against the current workflow SHA and exits before scheduler sync; pass an empty expected commit or skip this step when the deploy/wait is intentionally disabled.
Useful? React with 👍 / 👎.
| for entry in entries: | ||
| if isinstance(entry, Mapping): | ||
| target = _target_from_entry(entry) | ||
| if target: | ||
| targets.append(target) |
There was a problem hiding this comment.
load_targets now appends every target from SYNC_PLAN_JSON, but the surrounding workflow deploys, waits for, syncs env for, schedules, and prunes only CLOUD_RUN_SERVICE. In per-service configurations where CLOUD_RUN_SERVICE_TARGETS_JSON contains multiple services, a job for one service will also check and potentially shift traffic for the other services (or fail their commit check) even though they were not updated by this run; filter the reconciler to the current service like the existing verification step does.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation