Skip to content

Fix License - #89

Merged
cuttestkittensrule merged 3 commits into
mainfrom
kyle/fix-license
Dec 1, 2025
Merged

Fix License#89
cuttestkittensrule merged 3 commits into
mainfrom
kyle/fix-license

Conversation

@cuttestkittensrule

Copy link
Copy Markdown
Collaborator

Fixes a couple of issues with licensing

  1. We have the "how to add copyright comments" appendix in our license. We don't need it
    • Fixed in this PR by removing it
  2. We don't have any copyright comments in any files
    • Fixed for Java files by making spotless add the copyright message in java files as comments

Could add copyright comments in more kinds of files (see spotless docs for more info).
Also, do we want to enable automatic updating of the copyright? I haven't tested if this will work without git though

@spderman3333 spderman3333 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, though i think @vdikov should take a look too, as I have not played around with licencing.

@kcooney kcooney left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@cuttestkittensrule

Copy link
Copy Markdown
Collaborator Author

I looked at both spotless's code, and did a manual test. Spotless will work perfectly fine if git is not installed, as it doesn't shell out git. Do we want to make it automatically update the licenses of the files you change (if needed) when you make a change?

@kcooney

kcooney commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

I looked at both spotless's code, and did a manual test. Spotless will work perfectly fine if git is not installed, as it doesn't shell out git. Do we want to make it automatically update the licenses of the files you change (if needed) when you make a change?

Can we do that in a different PR? Lets submit this as-is.

@cuttestkittensrule
cuttestkittensrule merged commit cc0957a into main Dec 1, 2025
1 check passed
@cuttestkittensrule
cuttestkittensrule deleted the kyle/fix-license branch January 21, 2026 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants