Skip to content

Add vision project and PhotonVisionPosePublisher (from Robot2025) - #74

Merged
kcooney merged 13 commits into
mainfrom
kcooney/vision
Oct 19, 2025
Merged

Add vision project and PhotonVisionPosePublisher (from Robot2025)#74
kcooney merged 13 commits into
mainfrom
kcooney/vision

Conversation

@kcooney

@kcooney kcooney commented Oct 11, 2025

Copy link
Copy Markdown
Contributor
  • Create vision project in lib2813
  • Copy source files from Robot2025
  • Improve Javadoc
  • Remove unused constants, methods and classes
  • Readability improvements suggested by @spderman3333 and @vdikov

@kcooney
kcooney requested a review from spderman3333 October 11, 2025 01:50

@spderman3333 spderman3333 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if some of the more complex private methods are also documented as it increases code maintainability.

Comment thread vision/src/main/java/com/team2813/lib2813/vision/PhotonVisionPosePublisher.java Outdated
Comment thread vision/src/main/java/com/team2813/lib2813/vision/PhotonVisionPosePublisher.java Outdated
Comment thread vision/src/main/java/com/team2813/lib2813/vision/TimestampedStructPublisher.java Outdated
Comment thread vision/src/main/java/com/team2813/lib2813/vision/TimestampedStructPublisher.java Outdated
@kcooney

kcooney commented Oct 12, 2025

Copy link
Copy Markdown
Contributor Author

I would prefer if some of the more complex private methods are also documented as it increases code maintainability.

@spderman3333 could you add comments indicating which methods you would like me to add/improve documentation?

@kcooney
kcooney force-pushed the kcooney/vision branch 2 times, most recently from a61116a to 9a6dcd0 Compare October 12, 2025 21:11
@spderman3333

Copy link
Copy Markdown
Member

I would prefer if some of the more complex private methods are also documented as it increases code maintainability.

@spderman3333 could you add comments indicating which methods you would like me to add/improve documentation?

Will do later today.

@kcooney
kcooney requested a review from vdikov October 13, 2025 04:03

@spderman3333 spderman3333 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some nitpicks, that i think would just make the code a little more maintainable.

Comment thread vision/src/main/java/com/team2813/lib2813/vision/PhotonVisionPosePublisher.java Outdated
Comment thread vision/src/main/java/com/team2813/lib2813/vision/PhotonVisionPosePublisher.java Outdated
@kcooney
kcooney force-pushed the kcooney/vision branch 4 times, most recently from c58993a to e47196c Compare October 13, 2025 07:54
@kcooney
kcooney requested a review from spderman3333 October 15, 2025 04:25
Comment thread vision/build.gradle Outdated
@kcooney
kcooney merged commit 0da91d7 into main Oct 19, 2025
1 check passed
@kcooney
kcooney deleted the kcooney/vision branch October 19, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants