Skip to content

Add logging to try to diagnose SIGSEGV issues - #51

Merged
kcooney merged 6 commits into
mainfrom
kcooney/debug-sigsegvs
Sep 6, 2025
Merged

Add logging to try to diagnose SIGSEGV issues#51
kcooney merged 6 commits into
mainfrom
kcooney/debug-sigsegvs

Conversation

@kcooney

@kcooney kcooney commented Aug 24, 2025

Copy link
Copy Markdown
Contributor
  • Print message when tests start end complete
  • Print summary of test runs
  • Archive JVM crash logs and test logs
  • Update InputValidationTest to use @RunWith(Enclosed.class)
  • Add a delay before closing NetworkTableInstance in IsolatedPreferences

@kcooney
kcooney force-pushed the kcooney/debug-sigsegvs branch from 8309329 to 84f04b1 Compare August 24, 2025 05:43
@kcooney
kcooney force-pushed the kcooney/debug-sigsegvs branch from 84f04b1 to e2e8917 Compare August 24, 2025 05:50

@cuttestkittensrule cuttestkittensrule left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; We may want to include stderr on non-debug runs, but other than that, I don't have any comments. This also isn't the worst thing since all runs are debug by default here, so stderr will usually be included

@kcooney
kcooney force-pushed the kcooney/debug-sigsegvs branch 2 times, most recently from 79b47b1 to 81a6153 Compare September 4, 2025 08:49
@kcooney
kcooney force-pushed the kcooney/debug-sigsegvs branch from 81a6153 to 6d1b9a8 Compare September 4, 2025 08:49
@cuttestkittensrule

Copy link
Copy Markdown
Collaborator

fyi, the artifacts for the two SISEGV only have the hs_err_pid*.log, and not the html summary

@kcooney

kcooney commented Sep 6, 2025

Copy link
Copy Markdown
Contributor Author

fyi, the artifacts for the two SISEGV only have the hs_err_pid*.log, and not the html summary

My guess is the SIGSEGV killed the process that was processing the test results.

@kcooney

kcooney commented Sep 6, 2025

Copy link
Copy Markdown
Contributor Author

Looking at one of the crash logs, team2813 isn't anywhere on the stack frames.

I see multiple references to edu.wpi.first.networktables.NetworkTableInstance$ListenerStorage::lambda$startThread in the logs.

I'm guessing this is some kind of race condition between these threads and our calls to NetworkTableInstance.close()

@kcooney
kcooney force-pushed the kcooney/debug-sigsegvs branch from d7582a0 to 7c08f73 Compare September 6, 2025 01:08
@kcooney
kcooney force-pushed the kcooney/debug-sigsegvs branch from 7c08f73 to 6269fac Compare September 6, 2025 01:17
@kcooney

kcooney commented Sep 6, 2025

Copy link
Copy Markdown
Contributor Author

It's a race condition related to queued up network table events and the call to NetworkTableInstance.close(). I added a delay.

@kcooney
kcooney merged commit 9998ee2 into main Sep 6, 2025
1 check passed
@kcooney
kcooney deleted the kcooney/debug-sigsegvs branch September 23, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants