Add API to get the applied current of a motor - #33
Merged
Conversation
kcooney
reviewed
Mar 17, 2025
kcooney
approved these changes
Apr 30, 2025
| * | ||
| * @return The current applied current | ||
| */ | ||
| Current getAppliedCurrent(); |
Contributor
There was a problem hiding this comment.
Note that this isn't a backwards-compatible change. Since the version of 'lib' specified in build.gradle is "1.3.0-alpha.1" I'm guessing that's okay with you.
Optional: Perhaps add @since 1.3.0 to the Javadoc?
Collaborator
Author
There was a problem hiding this comment.
Since it is backwards incompatible, shouldn't we bump the major version?
I could change the build.gradle version to 2.0.0-alpha.1, so that the next release is 2.0.0
Contributor
There was a problem hiding this comment.
Since it is backwards incompatible, shouldn't we bump the major version?
If you want to follow the recommendations at https://semver.org/ then yes. You don't have to (JUnit didn't).
kcooney
added a commit
to Prospect-Robotics/Robot2025
that referenced
this pull request
Aug 23, 2025
This includes the following: - Prospect-Robotics/lib2813#33 - Prospect-Robotics/lib2813#44 - Prospect-Robotics/lib2813#45
kcooney
added a commit
to Prospect-Robotics/Robot2025
that referenced
this pull request
Aug 23, 2025
This includes the following: - Prospect-Robotics/lib2813#33 - Prospect-Robotics/lib2813#44 - Prospect-Robotics/lib2813#45 - Prospect-Robotics/lib2813#48
kcooney
added a commit
to Prospect-Robotics/Robot2025
that referenced
this pull request
Sep 4, 2025
This includes the following: - Prospect-Robotics/lib2813#33 - Prospect-Robotics/lib2813#44 - Prospect-Robotics/lib2813#45 - Prospect-Robotics/lib2813#48
kcooney
added a commit
to Prospect-Robotics/Robot2025
that referenced
this pull request
Sep 4, 2025
This includes the following: - Prospect-Robotics/lib2813#33 - Prospect-Robotics/lib2813#44 - Prospect-Robotics/lib2813#45 - Prospect-Robotics/lib2813#48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current getAppliedCurrent()toMotorto allow getting the applied current of a motorUnsupportedOperationExceptionbecause we might add a new motor that does not allow you to get the current of a motor in the future (this could be removed)Current getAppliedCurrent()for all current implemented motors