Update to the latest commit of lib2813 - #153
Merged
Merged
Conversation
kcooney
force-pushed
the
kcooney/upgrade-lib2813
branch
from
August 23, 2025 01:59
bb5a5d3 to
aac454c
Compare
kcooney
marked this pull request as ready for review
August 23, 2025 02:04
kcooney
marked this pull request as draft
August 23, 2025 02:38
kcooney
force-pushed
the
kcooney/upgrade-lib2813
branch
from
August 23, 2025 21:40
aac454c to
03359ba
Compare
kcooney
marked this pull request as ready for review
August 23, 2025 21:40
spderman3333
approved these changes
Sep 3, 2025
spderman3333
left a comment
spderman3333
left a comment
Member
There was a problem hiding this comment.
I did have some trouble properly cloning lib2813 with the branch, so we should consider a better alternative to submodules. Maybe as a maven artifact.
Collaborator
Author
Could you describe the problem? Were the instructions at https://github.com/Prospect-Robotics/Robot2025/blob/main/README.md helpful? The problem with having a maven artifact is finding a way to build the code while we are at an event that we do not have a good network. |
This includes the following: - Prospect-Robotics/lib2813#33 - Prospect-Robotics/lib2813#44 - Prospect-Robotics/lib2813#45 - Prospect-Robotics/lib2813#48
kcooney
force-pushed
the
kcooney/upgrade-lib2813
branch
from
September 4, 2025 05:12
03359ba to
b874439
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the following: