Use WPILibExtension from com.team2813:testing - #154
Merged
Conversation
kcooney
force-pushed
the
kcooney/upgrade-lib2813
branch
from
August 23, 2025 01:59
bb5a5d3 to
aac454c
Compare
kcooney
force-pushed
the
kcooney/use-lib2813-testing
branch
from
August 23, 2025 02:02
66e6c5b to
c90bd8e
Compare
kcooney
marked this pull request as ready for review
August 23, 2025 02:05
kcooney
marked this pull request as draft
August 23, 2025 02:38
kcooney
force-pushed
the
kcooney/upgrade-lib2813
branch
from
August 23, 2025 21:40
aac454c to
03359ba
Compare
kcooney
force-pushed
the
kcooney/use-lib2813-testing
branch
from
August 24, 2025 16:46
c90bd8e to
b5dfe2d
Compare
kcooney
marked this pull request as ready for review
August 24, 2025 16:46
Collaborator
|
LGTM. I'm recommending a review by @spderman3333 and giving him the opportunity to ask questions about how the two classes, |
spderman3333
approved these changes
Aug 31, 2025
spderman3333
left a comment
spderman3333
left a comment
Member
There was a problem hiding this comment.
LGTM, however, what does WPILibExtension do over CommandTesterExtension?
Collaborator
Author
I renamed the class when I moved it since it does more than just support testing of commands. |
Collaborator
Author
|
@spderman3333 BTW this PR depends on #153 |
kcooney
changed the title
kcooney
force-pushed
the
kcooney/upgrade-lib2813
branch
from
September 4, 2025 05:12
03359ba to
b874439
Compare
kcooney
force-pushed
the
kcooney/use-lib2813-testing
branch
from
September 4, 2025 05:18
b5dfe2d to
9eaf496
Compare
kcooney
force-pushed
the
kcooney/use-lib2813-testing
branch
from
September 4, 2025 05:20
9eaf496 to
3d552c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a replacement for
CommandTester(same functionality, different name, andnow in a shared location).