Skip to content

MultiPhotonPoseEstimator improvements - #140

Merged
kcooney merged 7 commits into
mainfrom
kcooney/vision-improvements
Jun 11, 2026
Merged

MultiPhotonPoseEstimator improvements#140
kcooney merged 7 commits into
mainfrom
kcooney/vision-improvements

Conversation

@kcooney

@kcooney kcooney commented Feb 14, 2026

Copy link
Copy Markdown
Contributor

New Builder Methods

  • Add withPoseFilter()
    • Poses that are not within the field are filtered out
  • Add withMultiTagFallbackStrategy()

Logging Support

  • Add an overload for processAllUnreadResults() that allows the caller
    to be notified of rejected poses

@kcooney
kcooney marked this pull request as ready for review February 14, 2026 03:18
@kcooney
kcooney force-pushed the kcooney/vision-improvements branch 2 times, most recently from 2de0cff to 5c117bd Compare February 14, 2026 03:27
@kcooney
kcooney force-pushed the kcooney/vision-improvements branch 6 times, most recently from e5161ff to 3de8b45 Compare February 14, 2026 22:11
@kcooney
kcooney changed the base branch from main to kcooney/vision-camera February 14, 2026 22:11
@kcooney
kcooney force-pushed the kcooney/vision-improvements branch 5 times, most recently from 1297f1d to 2f786d9 Compare February 15, 2026 21:23
@kcooney
kcooney changed the base branch from kcooney/vision-camera to main February 15, 2026 21:23
@kcooney
kcooney force-pushed the kcooney/vision-improvements branch from 2f786d9 to 9f3cb58 Compare February 16, 2026 20:25
@kcooney
kcooney requested a review from vdikov February 16, 2026 20:30
@kcooney
kcooney force-pushed the kcooney/vision-improvements branch 3 times, most recently from e25fc44 to 9a000de Compare March 10, 2026 02:46
@kcooney
kcooney force-pushed the kcooney/vision-improvements branch 2 times, most recently from cb7dba1 to 32371a9 Compare March 10, 2026 05:46
@kcooney
kcooney force-pushed the kcooney/vision-improvements branch from 32371a9 to 024489d Compare March 10, 2026 06:04
@kcooney kcooney assigned cuttestkittensrule and unassigned vdikov Mar 10, 2026

@cuttestkittensrule cuttestkittensrule left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@kcooney
kcooney merged commit 9420a35 into main Jun 11, 2026
1 check passed
@kcooney
kcooney deleted the kcooney/vision-improvements branch June 11, 2026 00:18
cuttestkittensrule pushed a commit that referenced this pull request Jun 11, 2026
**New Builder Methods**
  - Add `withPoseFilter()`
    - Poses that are not within the field are filtered out
  - Add `withMultiTagFallbackStrategy()`

**Logging Support**
- Add an overload for `processAllUnreadResults()` that allows the caller
  to be notified of rejected poses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants