Remove support for motors that use Phoenix 5 APIs - #103
Merged
Conversation
kcooney
marked this pull request as ready for review
December 30, 2025 01:20
Collaborator
|
One important thing to consider is if we care about any phoenix 5 exclusive stuff. There may be more, but the one example is the CANifier. This device has zero API on phoenix 6, and can only be used with phoenix 5. If we don't care, then there is no reason not to merge this |
Contributor
Author
If we ever need to support that, and we need a "configure and retry 3 times until there is no error" we can copy the code from another robot. |
vdikov
approved these changes
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.