feat(defaults): default winding names to 'Winding N'#9
Open
gpitel wants to merge 1 commit into
Open
Conversation
Name the default template windings 'Winding 1/2' instead of the isolation-side ordinals (Primary/Secondary); the isolationSide enum values are unchanged. Pairs with WebFrontend #23, which surfaces and edits these names in the Design Requirements rows. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Default the template windings to
Winding 1 / Winding 2instead of the isolation-side ordinals (Primary/Secondary). Only the human-readable windingnamedefaults change — theisolationSideenum values are untouched.Why
Winding names are user-facing, editable labels (Design Requirements, magnetic summary, winding selectors). Defaulting them to
Winding Nkeeps them from colliding with the isolation-side tags (which are also Primary/Secondary), so a row like "Winding 2 → Primary" reads unambiguously.Pairs with OpenMagnetics/WebFrontend#23, which surfaces these names in the Turns Ratios + Isolation Sides rows and names dynamically-added windings the same way.
🤖 Generated with Claude Code