Skip to content

fix(design-requirements): label per-winding rows 'WND<n>'#23

Open
gpitel wants to merge 1 commit into
OpenMagnetics:mainfrom
gpitel:claude/isolation-winding-labels-upstream
Open

fix(design-requirements): label per-winding rows 'WND<n>'#23
gpitel wants to merge 1 commit into
OpenMagnetics:mainfrom
gpitel:claude/isolation-winding-labels-upstream

Conversation

@gpitel

@gpitel gpitel commented Jun 18, 2026

Copy link
Copy Markdown

Problem

In the Design Requirements Isolation Sides editor, the left column shows each winding's ordinal name (Primary, Secondary, …), while its dropdown lists the isolation-side tag (also Primary, Secondary, …). With the same vocabulary in both columns, a row reads like a contradiction — e.g. "Secondary → Primary."

Fix

Label the left column WND1 / WND2 / … so it plainly identifies which winding the row is for; the dropdown still names the isolation group. A row now reads "WND2 → Primary" (winding 2 is on the primary side).

-                :replaceTitle="isolationSideOrdered[requirementIndex - 1]"
+                :replaceTitle="'WND' + requirementIndex"

Pure display change — the stored winding name and the isolationSide enum are untouched. Scoped to the Isolation Sides rows (the only ArrayElementFromList consumer); also drops the now-unused isolationSideOrdered import.

Before / After

Before — left column repeats the isolation-group vocabulary:

before

After — left column identifies the winding as WND1 / WND2 / …:

after

ℹ️ The "after" image above captures an earlier Winding <n> iteration of this label; the current code renders the compact WND<n> form. Screenshot pending refresh.

@gpitel gpitel marked this pull request as ready for review June 26, 2026 23:24
Replace the isolation-side names (Primary/Secondary/...) used as titles for the
per-winding array rows (Turns Ratios, Leakage Inductance, Stray Capacitance)
with compact, unambiguous 'WND<n>' labels.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@gpitel gpitel force-pushed the claude/isolation-winding-labels-upstream branch from 01a1acc to 5069f0e Compare June 27, 2026 10:42
@gpitel gpitel changed the title fix(design-requirements): label isolation rows "Winding N", not "Primary/Secondary" fix(design-requirements): label per-winding rows 'WND<n>' Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant