fix(design-requirements): label per-winding rows 'WND<n>'#23
Open
gpitel wants to merge 1 commit into
Open
Conversation
Replace the isolation-side names (Primary/Secondary/...) used as titles for the per-winding array rows (Turns Ratios, Leakage Inductance, Stray Capacitance) with compact, unambiguous 'WND<n>' labels. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
01a1acc to
5069f0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the Design Requirements Isolation Sides editor, the left column shows each winding's ordinal name (Primary, Secondary, …), while its dropdown lists the isolation-side tag (also Primary, Secondary, …). With the same vocabulary in both columns, a row reads like a contradiction — e.g. "Secondary → Primary."
Fix
Label the left column WND1 / WND2 / … so it plainly identifies which winding the row is for; the dropdown still names the isolation group. A row now reads "WND2 → Primary" (winding 2 is on the primary side).
Pure display change — the stored winding name and the
isolationSideenum are untouched. Scoped to the Isolation Sides rows (the onlyArrayElementFromListconsumer); also drops the now-unusedisolationSideOrderedimport.Before / After
Before — left column repeats the isolation-group vocabulary:
After — left column identifies the winding as
WND1 / WND2 / …: