Skip to content

Improve DB efficiency of SC shop handler #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yungcomputerchair wants to merge 1 commit into
base: main
Choose a base branch
from
+78 −62
Open

Improve DB efficiency of SC shop handler #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
140 changes: 78 additions & 62 deletions ....Gateway/Handlers/PacketBaseInGamePurchase/PacketInGamePurchasePlaceOrderPacketHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using System.Collections.Generic;
using System.Linq;

using Microsoft.EntityFrameworkCore;
Expand Down Expand Up @@ -99,7 +100,10 @@ public static bool HandlePacket(GatewayConnection connection, ReadOnlySpan<byte>

using var dbContext = _dbContextFactory.CreateDbContext();

var dbCharacter = dbContext.Characters.SingleOrDefault(x => x.Id == GuidHelper.GetPlayerId(connection.Player.Guid));
var dbCharacter = dbContext.Characters
.Include(x => x.Items)
.Include(x => x.Mounts)
.SingleOrDefault(x => x.Id == GuidHelper.GetPlayerId(connection.Player.Guid));

if (dbCharacter is null)
{
Expand All @@ -110,9 +114,10 @@ public static bool HandlePacket(GatewayConnection connection, ReadOnlySpan<byte>
return true;
}

var lastItemId = dbContext.Items.Where(i => i.CharacterId == dbCharacter.Id)
.Select(i => (int?)i.Id)
.Max() ?? 0;
var lastItemId = dbCharacter.Items.Count > 0 ? dbCharacter.Items.Max(i => i.Id) : 0;
var lastMountId = dbCharacter.Mounts.Count > 0 ? dbCharacter.Mounts.Max(x => x.Id) : 0;

var pendingUpdates = new List<Action>();

foreach (var bundleEntry in appStoreBundleDefinition.Entries)
{
Expand All @@ -129,7 +134,7 @@ public static bool HandlePacket(GatewayConnection connection, ReadOnlySpan<byte>
{
var totalQuantity = orderDetail.Quantity * bundleEntry.Quantity;

var dbItem = dbContext.Items.SingleOrDefault(i => i.CharacterId == dbCharacter.Id &&
var dbItem = dbCharacter.Items.SingleOrDefault(i =>
i.Definition == clientItemDefinition.Id && i.Tint == orderDetailTint);

if (dbItem is not null)
Expand All @@ -140,7 +145,7 @@ public static bool HandlePacket(GatewayConnection connection, ReadOnlySpan<byte>
{
dbItem = new DbItem
{
Id = lastItemId++ + 1,
Id = ++lastItemId,
Definition = clientItemDefinition.Id,
Tint = orderDetailTint,

Expand All @@ -150,53 +155,59 @@ public static bool HandlePacket(GatewayConnection connection, ReadOnlySpan<byte>
dbCharacter.Items.Add(dbItem);
}

var clientItem = connection.Player.Items.SingleOrDefault(x => x.Definition == clientItemDefinition.Id && x.Tint == orderDetailTint);

var addItem = false;
var itemDefinition = clientItemDefinition;
var savedItem = dbItem;

if (clientItem is not null)
{
clientItem.Count = dbItem.Count;
}
else
pendingUpdates.Add(() =>
{
addItem = true;
var clientItem = connection.Player.Items.SingleOrDefault(x => x.Definition == itemDefinition.Id && x.Tint == orderDetailTint);

var addItem = false;

clientItem = new ClientItem
if (clientItem is not null)
{
Id = dbItem.Id,
Tint = dbItem.Tint,
Count = dbItem.Count,
Definition = dbItem.Definition
};
clientItem.Count = savedItem.Count;
}
else
{
addItem = true;

connection.Player.Items.Add(clientItem);
}
clientItem = new ClientItem
{
Id = savedItem.Id,
Tint = savedItem.Tint,
Count = savedItem.Count,
Definition = savedItem.Definition
};

if (addItem)
{
using var writer = new PacketWriter();
connection.Player.Items.Add(clientItem);
}

clientItem.Serialize(writer);
if (addItem)
{
using var writer = new PacketWriter();

clientItemDefinition.Serialize(writer);
clientItem.Serialize(writer);

var clientUpdatePacketItemAdd = new ClientUpdatePacketItemAdd();
itemDefinition.Serialize(writer);

clientUpdatePacketItemAdd.Payload = writer.Buffer;
var clientUpdatePacketItemAdd = new ClientUpdatePacketItemAdd();

connection.SendTunneled(clientUpdatePacketItemAdd);
}
else
{
var clientUpdatePacketItemUpdate = new ClientUpdatePacketItemUpdate
{
ItemGuid = clientItem.Id,
Count = clientItem.Count,
};
clientUpdatePacketItemAdd.Payload = writer.Buffer;

connection.SendTunneled(clientUpdatePacketItemUpdate);
}
connection.SendTunneled(clientUpdatePacketItemAdd);
}
else
{
var clientUpdatePacketItemUpdate = new ClientUpdatePacketItemUpdate
{
ItemGuid = clientItem.Id,
Count = clientItem.Count,
};

connection.SendTunneled(clientUpdatePacketItemUpdate);
}
});
}
else if (clientItemDefinition.Type == 19) // Mounts
{
Expand All @@ -209,7 +220,7 @@ public static bool HandlePacket(GatewayConnection connection, ReadOnlySpan<byte>
return true;
}

if (connection.Player.Mounts.Any(x => x.Definition == mountDefinition.Id && x.TintId == orderDetailTint))
if (dbCharacter.Mounts.Any(x => x.Definition == mountDefinition.Id && x.Tint == orderDetailTint))
{
packetInGamePurchasePlaceOrderResponse.Result = 2;

Expand All @@ -218,13 +229,9 @@ public static bool HandlePacket(GatewayConnection connection, ReadOnlySpan<byte>
return true;
}

var lastMountId = dbContext.Mounts.Where(x => x.CharacterId == dbCharacter.Id)
.Select(x => (int?)x.Id)
.Max() ?? 0;

var dbMount = new DbMount
{
Id = lastMountId + 1,
Id = ++lastMountId,

Tint = orderDetailTint,
Definition = mountDefinition.Id,
Expand All @@ -233,24 +240,30 @@ public static bool HandlePacket(GatewayConnection connection, ReadOnlySpan<byte>

dbCharacter.Mounts.Add(dbMount);

connection.Player.Mounts.Add(new PacketMountInfo
{
Id = dbMount.Id,
Definition = mountDefinition.Id,
NameId = mountDefinition.NameId,
ImageSetId = mountDefinition.ImageSetId,
TintId = orderDetailTint,
MembersOnly = mountDefinition.MembersOnly,
IsUpgradable = mountDefinition.IsUpgradable,
IsUpgraded = dbMount.IsUpgraded
});
var mountDef = mountDefinition;
var savedMount = dbMount;

var packetMountList = new PacketMountList
pendingUpdates.Add(() =>
{
Mounts = connection.Player.Mounts
};
connection.Player.Mounts.Add(new PacketMountInfo
{
Id = savedMount.Id,
Definition = mountDef.Id,
NameId = mountDef.NameId,
ImageSetId = mountDef.ImageSetId,
TintId = orderDetailTint,
MembersOnly = mountDef.MembersOnly,
IsUpgradable = mountDef.IsUpgradable,
IsUpgraded = savedMount.IsUpgraded
});

var packetMountList = new PacketMountList
{
Mounts = connection.Player.Mounts
};

connection.Player.SendTunneled(packetMountList);
connection.Player.SendTunneled(packetMountList);
});
}
else
{
Expand All @@ -277,6 +290,9 @@ public static bool HandlePacket(GatewayConnection connection, ReadOnlySpan<byte>

connection.Player.StationCash = dbCharacter.StationCash;

foreach (var pendingUpdate in pendingUpdates)
pendingUpdate();

packetInGamePurchasePlaceOrderResponse.Result = 1;

packetInGamePurchasePlaceOrderResponse.OrderTrackingId = packet.Order.OrderTrackingId;
Expand Down