Improve DB efficiency of SC shop handler#55
Open
yungcomputerchair wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SC shop purchases are currently hammering the DB with a minimum of 4 database accesses per purchase (more if it's a multi-item bundle). Not only is this inefficient but it also is prone to desync with the client if one of the saves fails.
This PR refactors the SC shop purchase code to align with the Coin Shop purchase code, which does one read from the DB to get all the character's existing data and then one write with the changes applied. All the client-facing updates are deferred until after the DB commit so that the client either gets a success or a failure for all items.