Add WCD, GCDI, GCDM, WIPG, WIPL summary output for Field and Region#3408
Conversation
|
jenkins build this opm-simulators=4477 please |
bska
left a comment
bska
left a comment
There was a problem hiding this comment.
This looks good for the most part. I don't quite understand why CO2 volumes are reported in different units of measurement depending on the associate phase, but I also admit that I haven't looked too closely at this application.
| {"FGCDI" , Opm::UnitSystem::measure::liquid_surface_volume }, | ||
| {"FGCDM" , Opm::UnitSystem::measure::liquid_surface_volume }, | ||
| {"FWCD" , Opm::UnitSystem::measure::gas_surface_volume }, |
There was a problem hiding this comment.
This appears to use two different units of measurement for CO2, depending on whether it is in the gas phase (FG*) or in the water phase (FW*). Is that intentional?
| {"FGCDM" , Opm::UnitSystem::measure::liquid_surface_volume }, | ||
| {"FWCD" , Opm::UnitSystem::measure::gas_surface_volume }, | ||
| {"FWIPG" , Opm::UnitSystem::measure::liquid_surface_volume }, | ||
| {"FWIPL" , Opm::UnitSystem::measure::liquid_surface_volume } |
There was a problem hiding this comment.
Tiny nit, but could you put a trailing comma on the last entry here please? That way, it's slightly easier to add new entries when we need to.
totto82
force-pushed
the
summary_co2store
branch
from
eb86278 to
7e6f757
Compare
totto82
force-pushed
the
summary_co2store
branch
from
7e6f757 to
89850ad
Compare
|
jenkins build this opm-simulators=4477 please |
|
|
|
Seems to work as expected. Results are from modified CO2STORE test case. OPM/opm-tests#910 |
bska
left a comment
bska
left a comment
There was a problem hiding this comment.
Thanks a lot for the updates. I'll merge into master.
2 participants
These are summary output that is used for CO2STORE simulations.