WIP add WCD, GCDI, GCDM, WIPG, WIPL summary for F and R#4477
Conversation
| this->fip_[Inplace::Phase::GAS][globalDofIdx] += gasInPlaceWater; | ||
| } | ||
|
|
||
| Scalar criticalGas = 0.1; //TODO get this from the tables |
There was a problem hiding this comment.
@bska What is the best way to get the critical gas saturation here? Make it a member in this class and initialize from eclState via tables and satprop code?
There was a problem hiding this comment.
What is the best way to get the critical gas saturation here
Just to be sure: By "critical gas saturation" you mean the saturation at which the gas phase becomes mobile—i.e., exceeds the critical relative permeability tolerance ("TOLCRIT")? If so, you typically need to care about end-point scaling and/or hysteresis which varies by cell and/or system state. In that case, I think the most general approach is to go through
simulator_.problem().materialLawManager()
and effectively do the same that we do when computing the relative permeability. Storing this as a data member will just duplicate what we already have.
totto82
force-pushed
the
summary_co2store
branch
from
0dee039 to
d679ecd
Compare
bska
left a comment
bska
left a comment
There was a problem hiding this comment.
This looks good to me. With the caveat that I don't know how/if this works for the imbibition case I'm prepared to merge this. On a tangential note, I didn't notice that the immobile CO2 in the gas phase was tagged as CO2InGasPhaseInMob using the name InMob. At some point we might consider renaming that to CO2InGasPhaseImmob or similar instead.
| const auto& scaledDrainageInfo | ||
| = simulator_.problem().materialLawManager()->oilWaterScaledEpsInfoDrainage(globalDofIdx); |
There was a problem hiding this comment.
Are we intentionally deferring imbibition/hysteresis?
|
jenkins build this serial please |
|
I need to merge this now to restore the build following OPM/opm-common#3408 being merged. I'm still a little concerned about what to do with the imbibition curve, but we'll work on that as a refinement. For now we'll use the current version. |
2 participants
These are summary output that is used for CO2STORE simulations.
Depends on OPM/opm-common#3408