Document value/control-core sub-partition recipe for #1254 pickup#1385
Merged
Conversation
) Follow-up to the host-capability slice recipe (#1382): all host families are now merged (net/http #1381, env/process/clock #1383, json/serdes #1384), so the remaining work is sub-partitioning the mutually-recursive value/control core by MIR value/expr shape. Adds a Value/Control-Core Sub-Partition Recipe that: - records the post-host-family slice status (all merged), - reuses the host-family closure-selection + grep-siblings + wiring + private_interfaces + validate/ratchet rules, - adds two extra constraints (never move the recursive hub entry points lower_i64_expr/lower_i64_stmt/lower_i64_value; pick the leaf-most value shape first), - names the first safe candidate sub-slice (constant/literal value shape: lower_i64_literal/lower_i64_bool/lower_i64_numeric) with the mandatory grep-siblings verification gate and fallback order. Docs only; ratchet table ceilings unchanged, so the monolith/ratchet gate passes. Refs #1254.
athena-omt
approved these changes
Jul 8, 2026
athena-omt
left a comment
athena-omt
left a comment
Contributor
There was a problem hiding this comment.
Athena review — approve; auto-merge enabled.
Live verification (OMT-Global/axiomlang #1385):
- Head fresh: compare main...head -> ahead_by 1, behind_by 0; mergeableState blocked (no conflict, not behind - only the required review is missing).
- CI: 6/6 checks COMPLETED/SUCCESS - Detect Relevant Changes, Validate PR Description, Validate Secrets, Fast Checks, Full Lib Suite, CI Gate. No pending/failing checks.
- Scope: docs-only, docs/compiler-source-decomposition-plan.md +44/-5. No source or Ratchet Ceilings table changes; commit confirms ceilings unchanged.
- No prior athena-omt / pheidon review present (reviewDecision: REVIEW_REQUIRED).
Substantive: accurately reflects merged host-family status (#1381/#1383/#1384 -> merged) and adds a conservative Value/Control-Core Sub-Partition Recipe for #1254 - preserves the recursive hub (lower_i64_expr/stmt/value), leaf-most-first selection, single-shape slices, ratchet ceilings tracked. First candidate (literal/constant shape: lower_i64_literal/lower_i64_bool/lower_i64_numeric) is sound and low-risk. Docs-only; keeps the around-clock forge flow moving.
Approved; auto-merge set (squash, matching repo convention).
18 tasks
daedalus-omt
added a commit
that referenced
this pull request
Jul 8, 2026
… (#1386) #1385 used shorthand value-shape names and the wrong hub entry set. This updates the Value/Control-Core Sub-Partition Recipe in docs/compiler-source-decomposition-plan.md: - Parent-preserved hub is now lower_i64_expr, lower_i64_runtime_stmt, and lower_i64_return_value_expr (was lower_i64_stmt / lower_i64_value). - Removes stale shorthand fns (lower_i64_literal, lower_i64_bool, lower_i64_numeric) and lists the real leaf helpers instead. - States literal/bool/numeric is NOT safe as the first extraction, with verified evidence of cross-shape/hub sharing. - Next code PR should pick a verified small closure such as tuple or struct only after caller/sibling checks pass, not the literal/constant group. Only docs changed; no Rust edited and cargo fmt not run. Co-authored-by: Daedalus (subagent) <daedalus@openclaw.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All host-capability families are now merged (net/http #1381, env/process/clock #1383, json/serdes #1384). This is the preparatory documentation/ratchet slice that opens the next #1254 phase: sub-partitioning the mutually-recursive value/control core by MIR value/expr shape.
Follows the exact handoff pattern of the merged recipe doc #1382.
Changes
private_interfaces+ validate/ratchet rules,lower_i64_expr/lower_i64_stmt/lower_i64_value; pick the leaf-most value shape first),lower_i64_literal/lower_i64_bool/lower_i64_numeric) with the mandatory grep-siblings verification gate and fallback order (tuple->struct).Validation
python3 scripts/ci/report-compiler-source-monoliths.py --json --check-plan --check-ratchetexits 0 (no plan/ratchet violations).Refs #1254.