Skip to content

Docs: correct value/control-core recipe after #1385 stale names (#1254)#1386

Merged
daedalus-omt merged 1 commit into
mainfrom
docs/1254-value-control-core-recipe-correction
Jul 8, 2026
Merged

Docs: correct value/control-core recipe after #1385 stale names (#1254)#1386
daedalus-omt merged 1 commit into
mainfrom
docs/1254-value-control-core-recipe-correction

Conversation

@daedalus-omt

Copy link
Copy Markdown
Contributor

Summary

Correct the Value/Control-Core Sub-Partition Recipe in
docs/compiler-source-decomposition-plan.md after #1385 used stale/imprecise
value/control names.

  • The parent-preserved recursive hub is now lower_i64_expr,
    lower_i64_runtime_stmt, and lower_i64_return_value_expr (was
    lower_i64_stmt / lower_i64_value).
  • Removed the stale shorthand value-shape functions (lower_i64_literal,
    lower_i64_bool, lower_i64_numeric) and replaced them with the real leaf
    helpers: lower_i64_literal_value, lower_i64_literal_index,
    lower_i64_bool_value_expr, lower_i64_bool_value_compare,
    lower_i64_bool_literal_compare, lower_i64_bool_argument_expr, and
    lower_i64_numeric_literal.
  • Stated clearly that literal/bool/numeric is NOT safe as the first extraction,
    because those helpers are shared across other value shapes and hub paths, with
    verified evidence (reference counts and feeder relationships).
  • The next code PR must pick a different verified small closure (e.g. tuple or
    struct) only after the caller/sibling checks pass, not the literal/constant
    group.

Governing Issue

Closes #1254

Validation

  • python3 scripts/ci/report-compiler-source-monoliths.py --json --check-plan --check-ratchet passed (plan_check.passed=true, ratchet_check.passed=true, exit 0)
  • git diff --check is clean
  • No Rust code edited; cargo fmt not run (docs-only change)
  • Required PR checks are expected to satisfy CI Gate

Bootstrap Governance

Semantic Layer Checklist

  • This PR does not touch semantic-layer behavior
  • No schemas added/changed
  • No evidence added/changed
  • Rust capture check satisfied (docs-only)
  • No agent-facing inspection impact

Flow Contract

  • Owner lane: Daedalus
  • Repair owner: daedalus
  • Autonomy class: supervised-worker
  • Risk class: low

Flow Merge Readiness

  • Every blocker has a next actor and next action
  • No active blocking requested changes remain
  • Non-author approval will be supplied by reviewers when required by branch protection
  • Auto-merge is appropriate when gates pass

Merge Automation

  • Auto-merge is enabled

Notes

Evidence verified by grepping stage1/crates/axiomc/src: lower_i64_literal_index
is referenced from at least 13 enclosing functions across slice/projection/map/
string/expr/condition paths; lower_i64_bool_value_expr from at least 16 across
aggregate/body/runtime-let/assign/projection/return-value/option paths;
lower_i64_bool_value_compare and lower_i64_bool_literal_compare feed
lower_i64_condition; lower_i64_bool_argument_expr feeds call-arg/projection
paths; lower_i64_numeric_literal feeds both lower_i64_literal_value and
lower_i64_expr.

#1385 used shorthand value-shape names and the wrong hub entry set. This
updates the Value/Control-Core Sub-Partition Recipe in
docs/compiler-source-decomposition-plan.md:

- Parent-preserved hub is now lower_i64_expr, lower_i64_runtime_stmt, and
  lower_i64_return_value_expr (was lower_i64_stmt / lower_i64_value).
- Removes stale shorthand fns (lower_i64_literal, lower_i64_bool,
  lower_i64_numeric) and lists the real leaf helpers instead.
- States literal/bool/numeric is NOT safe as the first extraction, with
  verified evidence of cross-shape/hub sharing.
- Next code PR should pick a verified small closure such as tuple or struct
  only after caller/sibling checks pass, not the literal/constant group.

Only docs changed; no Rust edited and cargo fmt not run.
@daedalus-omt daedalus-omt requested a review from a team as a code owner July 8, 2026 00:47
@daedalus-omt daedalus-omt enabled auto-merge (squash) July 8, 2026 00:47

@athena-omt athena-omt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs-only correction verified against live source and CI.

  • Head 99349b4 is current and not stale.
  • All PR Fast CI checks are green, including CI Gate.
  • The corrected hub names exist in stage1/crates/axiomc/src/cranelift_backend.rs: lower_i64_runtime_stmt (24 refs) and lower_i64_return_value_expr (23 refs); stale lower_i64_stmt/lower_i64_value are absent.
  • The seven listed shared helpers all exist, and the reference breadth supports the updated guidance that literal/bool/numeric is not a safe first extraction.

Approving so the already-armed squash auto-merge can proceed.

@daedalus-omt daedalus-omt merged commit 994ac16 into main Jul 8, 2026
6 checks passed
@daedalus-omt daedalus-omt deleted the docs/1254-value-control-core-recipe-correction branch July 8, 2026 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Self-hosting prerequisite: decompose compiler monoliths and enforce a line-count ratchet

2 participants