Skip to content

cudaPackages.cuda_nvcc: do not patch crt/math_functions.h on cuda 13#488738

Merged
ConnorBaker merged 1 commit into
NixOS:masterfrom
GaetanLepage:cuda-maths
Feb 9, 2026
Merged

cudaPackages.cuda_nvcc: do not patch crt/math_functions.h on cuda 13#488738
ConnorBaker merged 1 commit into
NixOS:masterfrom
GaetanLepage:cuda-maths

Conversation

@GaetanLepage

@GaetanLepage GaetanLepage commented Feb 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Things done

Follow up to #484031.
The patch does not apply on cuda>=13.0:

substitute(): ERROR: file '/nix/store/30grlfcg220aky6r9a306sqs8jj8ljhh-cuda13.0-cuda_nvcc-13.0.88/include/crt/math_functions.h' does not exist

Caught on the NixOS-CUDA hydra instance: https://hydra.nixos-cuda.org/build/165433

cc @NixOS/cuda-maintainers

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot requested a review from a team February 9, 2026 14:19
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: cuda Parallel computing platform and API labels Feb 9, 2026
@GaetanLepage GaetanLepage mentioned this pull request Feb 9, 2026
Draft
13 tasks
ConnorBaker
ConnorBaker reviewed Feb 9, 2026
View reviewed changes
Comment thread pkgs/development/cuda-modules/packages/cuda_nvcc.nix Outdated
@ConnorBaker ConnorBaker self-assigned this Feb 9, 2026
@ConnorBaker

ConnorBaker commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

Why is python3Packages in the commit/PR title?

@GaetanLepage

GaetanLepage commented Feb 9, 2026

Copy link
Copy Markdown
Contributor Author

Why is python3Packages in the commit/PR title?

It's a mistake. Now fixed.

@GaetanLepage GaetanLepage changed the title python3Packages.cuda_nvcc: do not patch crt/math_functions.h on cuda 13 cudaPackages.cuda_nvcc: do not patch crt/math_functions.h on cuda 13 Feb 9, 2026
@ConnorBaker ConnorBaker added this pull request to the merge queue Feb 9, 2026
Merged via the queue into NixOS:master with commit 8b0dd85 Feb 9, 2026
45 of 47 checks passed
@github-project-automation github-project-automation Bot moved this from New to ✅ Done in CUDA Team Feb 9, 2026
@GaetanLepage GaetanLepage deleted the cuda-maths branch February 9, 2026 20:39
@GaetanLepage GaetanLepage mentioned this pull request Apr 23, 2026
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ConnorBaker ConnorBaker ConnorBaker approved these changes

Assignees

@ConnorBaker ConnorBaker

Labels

6.topic: cuda Parallel computing platform and API 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

CUDA Team
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GaetanLepage @ConnorBaker