Skip to content

cudaPackages.cuda_crt: patch math_functions.h signatures, python3Packages.deep-ep: cleanup, fix build on CUDA>=13.0#512796

Merged
GaetanLepage merged 2 commits into
NixOS:masterfrom
GaetanLepage:cuda-13-crt
Apr 24, 2026
Merged

cudaPackages.cuda_crt: patch math_functions.h signatures, python3Packages.deep-ep: cleanup, fix build on CUDA>=13.0#512796
GaetanLepage merged 2 commits into
NixOS:masterfrom
GaetanLepage:cuda-13-crt

Conversation

@GaetanLepage

@GaetanLepage GaetanLepage commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Things done

This PR addresses the mismatch in function declarations between glibc and cuda CRT.

The issue was already addressed for CUDA<13.0 (#484031), but is still relevant with CUDA>=13.0.
Indeed, the patch already targeted all CUDA versions, before realizing that it failed to apply on CUDA>=13.0.
Thus, it was removed in #488738, assuming it was not needed however.
Yet, while some functions are now fine (sinpi, cospi), rsqrtand rsqrtf still need to be patched.
They are not declared in cuda_nvcc anymore, but in cuda_crt.

cc @NixOS/cuda-maintainers

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@GaetanLepage GaetanLepage moved this from New to 👀 Awaits reviews in CUDA Team Apr 23, 2026
@nixpkgs-ci nixpkgs-ci Bot requested a review from a team April 23, 2026 14:52
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: cuda Parallel computing platform and API labels Apr 23, 2026

@samuela samuela left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@GaetanLepage

GaetanLepage commented Apr 23, 2026

Copy link
Copy Markdown
Contributor Author

The only failure (python3Packages.cuda-bindings.gpuCheck) is not a regression. I plan to address it in #512828.
-> merged!

@GaetanLepage GaetanLepage changed the title cudaPackages.cuda_crt: patch math_functions.h signatures cudaPackages.cuda_crt: patch math_functions.h signatures, python3Packages.deep-ep: cleanup, fix build on CUDA>=13.0 Apr 23, 2026
@GaetanLepage

Copy link
Copy Markdown
Contributor Author

All good!
https://hydra.nixos-cuda.org/eval/6751

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Apr 24, 2026
@GaetanLepage GaetanLepage added this pull request to the merge queue Apr 24, 2026
@GaetanLepage GaetanLepage moved this from 👀 Awaits reviews to ✅ Done in CUDA Team Apr 24, 2026
Merged via the queue into NixOS:master with commit 7c342c5 Apr 24, 2026
30 of 34 checks passed
@GaetanLepage GaetanLepage deleted the cuda-13-crt branch April 24, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: cuda Parallel computing platform and API 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants