cudaPackages.cuda_crt: patch math_functions.h signatures, python3Packages.deep-ep: cleanup, fix build on CUDA>=13.0#512796
Merged
Conversation
434a286 to
b0071c1
Compare
b0071c1 to
7c0d76e
Compare
Contributor
Author
|
|
7c0d76e to
6e46f91
Compare
Contributor
Author
|
All good! |
ConnorBaker
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
This PR addresses the mismatch in function declarations between glibc and cuda CRT.
The issue was already addressed for CUDA<13.0 (#484031), but is still relevant with CUDA>=13.0.
Indeed, the patch already targeted all CUDA versions, before realizing that it failed to apply on CUDA>=13.0.
Thus, it was removed in #488738, assuming it was not needed however.
Yet, while some functions are now fine (
sinpi,cospi),rsqrtandrsqrtfstill need to be patched.They are not declared in
cuda_nvccanymore, but incuda_crt.cc @NixOS/cuda-maintainers
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.