stratisd: 3.8.2 -> 3.8.6#460850
Merged
Merged
Conversation
13 tasks
Member
|
Does v3.8.6 fix any of these warnings? |
106a959 to
a9a8b0e
Compare
Contributor
Author
|
@NickCao Yea, I guess it does. I still think it's silly that they have warnings as errors enabled outside of CI, but I've changed the PR to just update the package, and I've run the |
NickCao
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If #457894 is merged before this, this needs to be retargeted to master.
Ideally the code just wouldn't trigger what appears to be new warnings as of the latest rust update, but it's silly that upstream enables errors on warnings, so deleting that seems like the best option.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.