Skip to content

stratisd: 3.8.2 -> 3.8.6#460850

Merged
NickCao merged 1 commit into
NixOS:masterfrom
ElvishJerricco:push-myulnrmomwsl
Nov 13, 2025
Merged

stratisd: 3.8.2 -> 3.8.6#460850
NickCao merged 1 commit into
NixOS:masterfrom
ElvishJerricco:push-myulnrmomwsl

Conversation

@ElvishJerricco

Copy link
Copy Markdown
Contributor

If #457894 is merged before this, this needs to be retargeted to master.

Ideally the code just wouldn't trigger what appears to be new warnings as of the latest rust update, but it's silly that upstream enables errors on warnings, so deleting that seems like the best option.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@ElvishJerricco ElvishJerricco mentioned this pull request Nov 12, 2025
13 tasks
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Nov 12, 2025
@nixpkgs-ci nixpkgs-ci Bot requested a review from NickCao November 12, 2025 05:43
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Nov 12, 2025
@vcunat vcunat changed the base branch from staging-next to master November 12, 2025 18:18
@nixpkgs-ci nixpkgs-ci Bot closed this Nov 12, 2025
@nixpkgs-ci nixpkgs-ci Bot reopened this Nov 12, 2025
@NickCao

NickCao commented Nov 12, 2025

Copy link
Copy Markdown
Member

Does v3.8.6 fix any of these warnings?

@ElvishJerricco

Copy link
Copy Markdown
Contributor Author

@NickCao Yea, I guess it does. I still think it's silly that they have warnings as errors enabled outside of CI, but I've changed the PR to just update the package, and I've run the stratis and installer-systemd-stage-1.stratis NixOS tests.

@ElvishJerricco ElvishJerricco changed the title stratisd: Don't error on warning stratisd: 3.8.2 -> 3.8.6 Nov 13, 2025
@NickCao NickCao added this pull request to the merge queue Nov 13, 2025
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Nov 13, 2025
Merged via the queue into NixOS:master with commit f0cdd64 Nov 13, 2025
29 of 33 checks passed
@ElvishJerricco ElvishJerricco deleted the push-myulnrmomwsl branch March 7, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants