systemd: 258.1 -> 258.2#459973
Merged
Merged
Conversation
ElvishJerricco
commented
Nov 9, 2025
ElvishJerricco
left a comment
Contributor
Author
There was a problem hiding this comment.
Marked as draft while I build tests.
Comment on lines
-224
to
-233
| # https://github.com/systemd/systemd/pull/39094 | ||
| (fetchpatch { | ||
| url = "https://github.com/systemd/systemd/commit/8b4ee3d68d2e70d9a396b74d155eab3b11763311.patch"; | ||
| hash = "sha256-JJDaSHQjd1QZ18CQHq40viB0AF/0MiescmZUcc/6LDg="; | ||
| }) | ||
| (fetchpatch { | ||
| url = "https://github.com/systemd/systemd/commit/13b0e7fc6d2623800ba04b104f3b628388c9f5e6.patch"; | ||
| hash = "sha256-X+tY3NjfRJpF6wvd++xEps0DIFTbX/6Zw9oO4Y9FmNI="; | ||
| }) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
In 258, I included the whole PR these were from. In 258.1, only one of them was backported, so I just included the other two specifically here. Now in 258.2, the one I actually cared about (8b4ee3d68d2e70d9a396b74d155eab3b11763311) was backported, but the other one wasn't. Given the last one wasn't anything all that important and wasn't deemed worth backporting upstream, I figure we should just drop it too.
185c193 to
7f637c8
Compare
Given the nature of the command, our backdoor is likely to be killed before it can return the status to the test driver.
7f637c8 to
32220aa
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.