gamdl: init at 2.8#432872
Conversation
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
8536c90 to
e95b7c7
Compare
|
nixpkgs-ci
Bot
removed
the
9.needs: reviewer
nixpkgs-ci
Bot
added
6.topic: python
c252f72 to
3e159e7
Compare
|
I believe I have made all the changes you requested. Are there any other issues? |
3e159e7 to
51156c0
Compare
|
Missing |
|
I apologize, but I am feeling quite overwhelmed at the moment. I will organize my thoughts and request your review once I have done so. |
|
Dear @Sigmanificient Actually, I'm not very familiar with how to integrate Python modules into nixpkgs. Currently, the files in the latest commit version can be successfully built on my local machine, but the built files cannot be executed smoothly. Could you please help me with this? |
e728356 to
e043570
Compare
There was a problem hiding this comment.
@bdim404 I tried to cleanup a bit the pr for you. Unfortunately, pymp4 tests are still failing. After some investigation, this is caused by construct dependency, being not compatible with the one expected. There is a pr that tries to upgrade from Construct 2.8.8 to 2.10.68, but it seems that more work it needed to make it work with python 3.13
|
Thank you very much for your help! In your opinion, how should this situation be handled and resolved? |
|
Well a patch that makes |
Currently, pymp4 is unavailable, and we still need to make changes. Won't we need to rebase again? Wouldn't it be better to organize the commits after we can run it? |
That's up to you. Although I do think rebasing it right now is better since the commit message is very generic, and it's harder to track which commit did what once commits get built up. |
e2bd184 to
c8c4aa6
Compare
nixpkgs-ci
Bot
removed
the
8.has: maintainer-list (update)
c950dd0 to
a68ffd4
Compare
|
Hi @Sigmanificient, I tried to make a patch for pymp4, and it works well, pls check it. |
|
Python implementation of Google's Widevine DRM CDM (Content Decryption Module). Includes a patch for construct 2.10+ compatibility. Co-authored-by: Yohann Boniface <edhyjox@gmail.com>
Python library for parsing and manipulating MP4 files. Uses the devine-dl fork with construct 2.10+ compatibility from upstream PR NixOS#24.
Command-line tool for downloading Apple Music songs, music videos and post videos. Automatically embeds metadata, lyrics, and cover art. Co-authored-by: Yohann Boniface <edhyjox@gmail.com>
a68ffd4 to
62ce148
Compare
bdim404
added
the
9.needs: reviewer
nixpkgs-ci
Bot
removed
the
9.needs: reviewer
|
yzhou216
left a comment
yzhou216
left a comment
There was a problem hiding this comment.
Approved automatically following the successful run of nixpkgs-review.
nixpkgs-ci
Bot
added
the
12.approvals: 1
There was a problem hiding this comment.
Why is doCheck = false here?
There was a problem hiding this comment.
Tests are disabled because 10 out of 27 tests fail with offset/end field mismatches.
All failing tests show the same pattern:
- Expected: offset=0, end=X
- Actual: offset=4, end=X+4
This indicates a 4-byte offset discrepancy (the size of an MP4 box header),likely due to changes in the construct library behavior or outdated test expectations. The library itself remains functional for its intended use (as a dependency for gamdl), so tests are disabled to allow packaging.
Failed tests:
- test_ftyp_parse, test_mdhd_parse, test_smhd_parse, test_stsd_parse
- test_tenc_parse
- test_iden_parse, test_payl_parse, test_sttg_parse, test_vlab_parse, test_vttC_parse
nixpkgs-ci
Bot
added
the
2.status: stale
4 participants
This PR introduces the
gamdlpackage.gamdlis a command-line tool for downloading songs, albums, playlists, and music videos from Apple Music. It automatically embeds metadata, lyrics, and cover art into the downloaded files. This is useful for users who want to maintain an offline backup of their Apple Music library.Homepage: https://github.com/glomatico/gamdl
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.