onthespot: 0.5 -> 1.0.4

[ryand56]

Changes to a maintained fork of onthespot.
https://github.com/justin025/onthespot/releases/tag/v1.0.4

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[onny]

Looks nice, thank you!

Would be nice if you could split up the commit into several ones like onthespot: modernize package, onthespot: add XYZ as maintainer etc

[onny]

When trying to run the client I get

[nix-shell:~/.cache/nixpkgs-review/pr-356878]$ ./results/onthespot/bin/onthespot-cli 
Traceback (most recent call last):
  File "/nix/store/4z48icnrwszkr2yrb3k6cgmakb3iivbd-onthespot-1.0.2/bin/..onthespot-cli-wrapped-wrapped", line 6, in <module>
    from onthespot.cli import main
  File "/nix/store/4z48icnrwszkr2yrb3k6cgmakb3iivbd-onthespot-1.0.2/lib/python3.12/site-packages/onthespot/__init__.py", line 7, in <module>
    from .gui.mainui import MainWindow
  File "/nix/store/4z48icnrwszkr2yrb3k6cgmakb3iivbd-onthespot-1.0.2/lib/python3.12/site-packages/onthespot/gui/mainui.py", line 9, in <module>
    from ..utils import is_latest_release, open_item
  File "/nix/store/4z48icnrwszkr2yrb3k6cgmakb3iivbd-onthespot-1.0.2/lib/python3.12/site-packages/onthespot/utils.py", line 8, in <module>
    from librespot.core import Session
  File "/nix/store/6xpywqzd46wcw111pk7642ixnfbx0jnk-python3.12-librespot-0.0.9/lib/python3.12/site-packages/librespot/__init__.py", line 3, in <module>
    from librespot.proto.Keyexchange_pb2 import BuildInfo, Platform, Product, ProductFlags
  File "/nix/store/6xpywqzd46wcw111pk7642ixnfbx0jnk-python3.12-librespot-0.0.9/lib/python3.12/site-packages/librespot/proto/Keyexchange_pb2.py", line 31, in <module>
    _descriptor.EnumValueDescriptor(
  File "/nix/store/qs1dq3148cidflfqkl7nlg8qij0m77ja-python3.12-protobuf-5.28.3/lib/python3.12/site-packages/google/protobuf/descriptor.py", line 920, in __new__
    _message.Message._CheckCalledFromGeneratedFile()
TypeError: Descriptors cannot be created directly.
If this call came from a _pb2.py file, your generated code is out of date and must be regenerated with protoc >= 3.19.0.
If you cannot immediately regenerate your protos, some other possible workarounds are:
 1. Downgrade the protobuf package to 3.20.x or lower.
 2. Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python parsing and will be much slower).

More information: https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates

[ryand56]

That's weird, I did set that environment variable.

[eclairevoyant]

I see that this fork has had releases since, does v1.2.4 still work? If so I'll remove it from my PR #446400

[ryand56]

Just went ahead and updated, but this needs pywidevine. Looks like it was being added in #432872

[ryand56]

After adding all those dependencies, still broken:

Traceback (most recent call last):
  File "/nix/store/14l51qx5yip5dlzp41xaavisz59z25yg-onthespot-1.1.2/bin/..onthespot-cli-wrapped-wrapped", line 6, in <module>
    from onthespot.cli import main
  File "/nix/store/14l51qx5yip5dlzp41xaavisz59z25yg-onthespot-1.1.2/lib/python3.12/site-packages/onthespot/cli.py", line 12, in <module>
    from .accounts import FillAccountPool, get_account_token
  File "/nix/store/14l51qx5yip5dlzp41xaavisz59z25yg-onthespot-1.1.2/lib/python3.12/site-packages/onthespot/accounts.py", line 3, in <module>
    from .api.apple_music import apple_music_login_user, apple_music_get_token
  File "/nix/store/14l51qx5yip5dlzp41xaavisz59z25yg-onthespot-1.1.2/lib/python3.12/site-packages/onthespot/api/apple_music.py", line 9, in <module>
    from pywidevine import PSSH, Cdm, Device
  File "/nix/store/3693d8x3pfmgr8g2my7xwy7xqvh05s5y-python3.12-pywidevine-1.8.0/lib/python3.12/site-packages/pywidevine/__init__.py", line 1, in <module>
    from .cdm import *
  File "/nix/store/3693d8x3pfmgr8g2my7xwy7xqvh05s5y-python3.12-pywidevine-1.8.0/lib/python3.12/site-packages/pywidevine/cdm.py", line 21, in <module>
    from pywidevine.device import Device, DeviceTypes
  File "/nix/store/3693d8x3pfmgr8g2my7xwy7xqvh05s5y-python3.12-pywidevine-1.8.0/lib/python3.12/site-packages/pywidevine/device.py", line 25, in <module>
    class _Structures:
  File "/nix/store/3693d8x3pfmgr8g2my7xwy7xqvh05s5y-python3.12-pywidevine-1.8.0/lib/python3.12/site-packages/pywidevine/device.py", line 36, in _Structures
    "version" / Const(Int8ub, 2),
                ^^^^^^^^^^^^^^^^
  File "/nix/store/8fal0zpgxky1pi546ygyryy2wgqnmcfb-python3.12-construct-2.10.70/lib/python3.12/site-packages/construct/core.py", line 2838, in __init__
    super().__init__(subcon)
  File "/nix/store/8fal0zpgxky1pi546ygyryy2wgqnmcfb-python3.12-construct-2.10.70/lib/python3.12/site-packages/construct/core.py", line 792, in __init__
    raise TypeError("subcon should be a Construct field")
TypeError: subcon should be a Construct field

I think we should drop this. It's relying on broken dependencies.

[eclairevoyant]

Thanks for looking into it and confirming 🎉