dcgm: 3.3.5 -> 3.3.9; cudaPackages_10{,_0,_1,_2}: drop#357655
Merged
Conversation
github-actions
Bot
added
6.topic: python
emilazy
changed the title
13 tasks
de11n
approved these changes
Nov 20, 2024
de11n
left a comment
de11n
left a comment
There was a problem hiding this comment.
Wow, thank you for cleaning up and fixing DCGM. I had poked at it a while ago and didn't have time to push it forward. This is a great improvement.
de11n
reviewed
Nov 20, 2024
Comment on lines
62
to
63
There was a problem hiding this comment.
I guess gcc11 is no longer strictly required?
Member
Author
There was a problem hiding this comment.
Ah, yes, I just forgot to drop this comment; it’s building with GCC 13 now. Fixed :)
emilazy
force-pushed
the
push-zyuzyylslsrp
branch
from
d084bda to
a16584e
Compare
de11n
approved these changes
Nov 20, 2024
ofborg
Bot
added
the
2.status: merge conflict
Fixes the build and matches upstream in dropping CUDA 10. Diff: NVIDIA/DCGM@refs/tags/v3.3.5...v3.3.9
Static CUDA seems to be broken anyway, the upstream build system is awkward and uncooperative, and it’s simpler to just patch it to use dynamic libraries.
Just a few missing includes, really nothing too bad at all.
It’s been marked as broken for over a year and requires CUDA 10. Even the non‐CUDA variant of the package refused to evaluate without enabling broken packages due to `cudnn`, so I’m not sure anyone is using this package at all…
emilazy
force-pushed
the
push-zyuzyylslsrp
branch
from
a16584e to
e3d26a1
Compare
Member
Author
|
Rebased for conflicts. |
de11n
approved these changes
Nov 22, 2024
ConnorBaker
approved these changes
Nov 22, 2024
ConnorBaker
left a comment
ConnorBaker
left a comment
Contributor
There was a problem hiding this comment.
Thank you for taking this on!
wegank
added
the
12.approvals: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An update of DCGM to a newer version that has dropped CUDA 10 support upstream, fixing the build and cleaning it up a bit in the process, and a scheduled visit from the reaper now that 24.11 has branched off and this is the last thing standing in the way of my unsupported‐compiler‐removing rampage. See the commit messages for details. CUDA 11 lives for now, mostly pending action on #345658, though it’s not urgent as there are other blockers to removing the slightly newer GCCs that I have to deal with first.
I don’t use DCGM, so cc @de11n for testing. It passes tests that we weren’t running before, at least.
nixpkgs-reviewresultGenerated using
nixpkgs-review.Command:
nixpkgs-reviewx86_64-linux⏩ 1 package blacklisted:
✅ 12 packages built:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.