{gcc{7,8}{,Stdenv},gfortran{7,8}}: drop#357657
Merged
Merged
Conversation
github-actions
Bot
added
6.topic: python
emilazy
force-pushed
the
push-wtzsmtkxryqy
branch
from
4fee11a to
21d3de7
Compare
ofborg
Bot
added
the
2.status: merge conflict
emilazy
force-pushed
the
push-wtzsmtkxryqy
branch
from
21d3de7 to
59bdbc9
Compare
Release branch from 7½ years ago, no update in 5 years, unsupported upstream, and unused in tree.
Upstream previously recommended GCC 8 when targeting AVR because of binary size concerns. They have since removed this warning in <qmk/qmk_firmware#24206>, as more recent GCC versions have resolved the issues. Building `keyboardio/model01` before: * The firmware size is fine - 26984/28672 (94%, 1688 bytes free) And after: * The firmware size is fine - 27200/28672 (94%, 1472 bytes free) +216 bytes (1.008× the total size) is not a big deal. Since upstream is fine with it these days, we can be too, and not keep around an unsupported compiler just for QMK.
Release branch from 6½ years ago, no update in 3½ years, unsupported upstream, and unused in tree. This finally resolves the tangled conditionals in `all.nix`, albeit in a way I assume amjoseph wouldn’t have been too fond of. `default.nix` still has some gnarly stuff in there. So it goes…
emilazy
force-pushed
the
push-wtzsmtkxryqy
branch
from
59bdbc9 to
20c5d92
Compare
Member
Author
|
This is ready now. |
github-actions
Bot
removed
6.topic: python
ofborg
Bot
added
8.has: clean-up
ofborg
Bot
added
10.rebuild-darwin: 1-10
philiptaron
approved these changes
Nov 23, 2024
wegank
added
the
12.approvals: 1
8 tasks
This was referenced Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6½–7½ year old unsupported GCC branches that basically nothing uses; you know the drill. Continuing @trofi’s work in #342242 now that the CUDA blocker has been resolved (though I wrote the GCC 7 commit here independently). We’ll have to stop here for a bit until in‐tree users of CUDA 11 are dealt with and I finish moving a couple other packages off old GCCs.
This depends on #357655 and therefore includes the commits from that PR until it is merged; best to look at the individual commits on top if you want to review it early.nixpkgs-reviewresultGenerated using
nixpkgs-review.Command:
nixpkgs-reviewx86_64-linux✅ 2 packages built:
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.