thrift: 0.18.1 -> 0.20.0#296770
Closed
anthonyroussel wants to merge 6 commits into
Closed
Conversation
ofborg
Bot
added
11.by: package-maintainer
anthonyroussel
force-pushed
the
update-thrift
branch
from
7b2b393 to
0ee776a
Compare
Contributor
|
Result of 32 packages marked as broken and skipped:
493 packages failed to build:
|
bjornfor
requested changes
Mar 18, 2024
bjornfor
left a comment
bjornfor
left a comment
Contributor
There was a problem hiding this comment.
493 packages failed to build:
Looks like thrift itself fails, and then all dependees are marked as failed too.
anthonyroussel
force-pushed
the
update-thrift
branch
from
0ee776a to
6a00822
Compare
Member
Author
|
I fixed the failing locales tests on *-linux platforms. I still have to investigate why the |
anthonyroussel
force-pushed
the
update-thrift
branch
3 times, most recently
from
6a24f80 to
55978db
Compare
anthonyroussel
force-pushed
the
update-thrift
branch
from
55978db to
bab9879
Compare
Member
Author
|
Update thrift to 0.20: apache/thrift@v0.18.1...v0.20.0 |
anthonyroussel
force-pushed
the
update-thrift
branch
from
bab9879 to
a07b2f9
Compare
Member
Author
|
Rebased against master |
Contributor
|
Result of 44 packages marked as broken and skipped:
441 packages failed to build:
200 packages built:
|
anthonyroussel
force-pushed
the
update-thrift
branch
from
a07b2f9 to
4f0a662
Compare
anthonyroussel
force-pushed
the
update-thrift
branch
from
4f0a662 to
1f1dd00
Compare
wegank
added
the
2.status: merge conflict
Member
|
@anthonyroussel Could you rebase your changes |
anthonyroussel
force-pushed
the
update-thrift
branch
from
1f1dd00 to
360b082
Compare
anthonyroussel
removed
the
2.status: merge conflict
Member
Author
|
@ofborg build thrift |
Member
Author
|
Result of 49 packages marked as broken and skipped:
133 packages failed to build:
293 packages built:
Most of the 133 packages are already failing on Hydra for darwin. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4242 |
Member
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 128 packages marked as broken and skipped:
42 packages failed to build and already failed to build on hydra master:
368 packages failed to build and are new build failures:
116 packages built:
The following issues got detected with the above build packages. DetailsapacheHttpdPackages.mod_tile:warning: unnecessary-parallel-building Near pkgs/servers/http/apache-modules/mod_tile/default.nix:57:3: got build log for '/nix/store/40bfdlyybsapk881gdg61pwhaz9bddj1-arrow-cpp-16.0.0' from 'daemon' warning: unnecessary-parallel-building Near pkgs/tools/filesystems/ceph/default.nix:343:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unnecessary-parallel-building.md Near pkgs/tools/filesystems/ceph/default.nix:143:6: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md Near pkgs/tools/filesystems/ceph/default.nix:345:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md warning: unnecessary-parallel-building Near pkgs/development/libraries/gdal/default.nix:210:3: got build log for '/nix/store/xmv101f8jml3jrcb83x70vxfpna0g1k8-gnss-sdr-0.0.19.1' from 'daemon' Near pkgs/development/gnuradio-modules/mkDerivation.nix:24:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unnecessary-parallel-building.md Near pkgs/applications/radio/gnss-sdr/default.nix:100:3: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: unclear-gpl Near pkgs/applications/radio/gnuradio/shared.nix:139:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unnecessary-parallel-building Near pkgs/development/gnuradio-modules/mkDerivation.nix:24:5: warning: unnecessary-parallel-building Near pkgs/development/gnuradio-modules/mkDerivation.nix:24:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unnecessary-parallel-building.md Near pkgs/development/gnuradio-modules/mkDerivation.nix:29:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md Near pkgs/development/gnuradio-modules/mkDerivation.nix:29:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md warning: unnecessary-parallel-building Near pkgs/development/gnuradio-modules/mkDerivation.nix:24:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unnecessary-parallel-building.md warning: unnecessary-parallel-building Near pkgs/development/gnuradio-modules/mkDerivation.nix:24:5: warning: unnecessary-parallel-building Near pkgs/development/gnuradio-modules/mkDerivation.nix:24:5: got build log for '/nix/store/xjwgi7f30vz71pdgv6wzcrxdhk5hik66-gnuradio-wrapped-3.9.8.0' from 'daemon' Near pkgs/applications/radio/gnuradio/shared.nix:139:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unnecessary-parallel-building Near pkgs/development/gnuradio-modules/mkDerivation.nix:24:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unnecessary-parallel-building.md Near pkgs/development/gnuradio-modules/mkDerivation.nix:29:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md warning: unnecessary-parallel-building Near pkgs/development/gnuradio-modules/mkDerivation.nix:24:5: got build log for '/nix/store/qz8lbj4gp0dd34axpajf97c0np6pm09z-gnuradio-wrapped-3.10.10.0' from 'daemon' Near pkgs/applications/radio/gnuradio/shared.nix:139:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md warning: unnecessary-parallel-building Near pkgs/development/gnuradio-modules/mkDerivation.nix:24:5: warning: maintainers-missing Near pkgs/applications/science/misc/gplates/default.nix:68:3: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: maintainers-missing Near pkgs/development/haskell-modules/generic-builder.nix:819:3: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md Near pkgs/development/haskell-modules/generic-builder.nix:431:3: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md Near pkgs/development/haskell-modules/generic-builder.nix:431:3: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md Near pkgs/development/haskell-modules/generic-builder.nix:431:3: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md Near pkgs/development/haskell-modules/generic-builder.nix:431:3: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md Near pkgs/development/haskell-modules/generic-builder.nix:431:3: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md Near pkgs/development/haskell-modules/generic-builder.nix:431:3: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md error: build log of '/nix/store/1drmaslhw97da3vgna1hy6b9f6wky6p3-jcef-jetbrains-867' is not available Near pkgs/development/compilers/jetbrains-jdk/jcef.nix:284:3: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: unused-argument got build log for '/nix/store/1jx4qfjapsk954fk3lmqvy8f20hbnj41-jetbrains-jdk-jcef-21.0.3-b465.3-debug' from 'daemon' got build log for '/nix/store/985brwlk015lba33wx44ph1z3h9fs5v5-jetbrains-jdk-jcef-21.0.3-b465.3' from 'daemon' warning: patch-phase Near pkgs/development/interpreters/octave/build-octave-package.nix:96:10: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/patch-phase.md warning: unused-argument warning: unused-argument got build log for '/nix/store/pm4pi531lpm43s9f47w2gdvgwhllqrga-python3.11-datasets-2.20.0-dist' from 'daemon' Near pkgs/development/python-modules/datasets/default.nix:73:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md got build log for '/nix/store/hbgsnxpvzh9wdb7wkcs1fxgynayxrl1q-python3.11-datasets-2.20.0' from 'daemon' Near pkgs/development/python-modules/datasets/default.nix:73:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: maintainers-missing Near pkgs/development/python-modules/datashader/default.nix:99:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: maintainers-missing Near pkgs/development/python-modules/datashader/default.nix:99:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: maintainers-missing Near pkgs/development/python-modules/db-dtypes/default.nix:46:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: maintainers-missing Near pkgs/development/python-modules/db-dtypes/default.nix:46:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: unused-argument warning: unused-argument warning: maintainers-missing Near pkgs/development/python-modules/folium/default.nix:72:3: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: maintainers-missing Near pkgs/development/python-modules/folium/default.nix:72:3: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: maintainers-missing Near pkgs/development/python-modules/google-cloud-bigquery/default.nix:135:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: maintainers-missing Near pkgs/development/python-modules/google-cloud-bigquery/default.nix:135:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: unused-argument warning: unused-argument warning: python-include-tests Near pkgs/development/python-modules/influxdb3-python/default.nix:50: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md warning: python-include-tests Near pkgs/development/python-modules/influxdb3-python/default.nix:50: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md warning: maintainers-missing Near pkgs/development/python-modules/intake/default.nix:140:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: maintainers-missing Near pkgs/development/python-modules/intake/default.nix:140:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: python-include-tests Near pkgs/development/python-modules/intake-parquet/default.nix:54: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md warning: python-include-tests Near pkgs/development/python-modules/intake-parquet/default.nix:54: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md warning: maintainers-missing Near pkgs/development/python-modules/python-mapnik/default.nix:133:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: maintainers-missing Near pkgs/development/python-modules/python-mapnik/default.nix:133:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md got build log for '/nix/store/2rrqb31nfgzmqjc9ks9zc30zzapy7f3s-python3.11-streamz-0.6.4-dist' from 'daemon' Near pkgs/development/python-modules/streamz/default.nix:84:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md got build log for '/nix/store/jmig1pjjj9gfdkgczavv0bpfrr2iw0a4-python3.11-streamz-0.6.4' from 'daemon' Near pkgs/development/python-modules/streamz/default.nix:84:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: maintainers-missing Near pkgs/development/python-modules/tokenizers/default.nix:140:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md error: build log of '/nix/store/d7n5mfap103fmcfgc034wqh4ha9zbz0k-python3.11-tokenizers-0.19.1' is not available Near pkgs/development/python-modules/tokenizers/default.nix:140:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: unused-argument warning: unused-argument warning: maintainers-missing Near pkgs/development/python-modules/datasets/default.nix:73:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: maintainers-missing Near pkgs/development/python-modules/datasets/default.nix:73:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: maintainers-missing Near pkgs/development/python-modules/db-dtypes/default.nix:46:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: maintainers-missing Near pkgs/development/python-modules/db-dtypes/default.nix:46:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: unused-argument warning: unused-argument warning: maintainers-missing Near pkgs/development/python-modules/folium/default.nix:72:3: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: maintainers-missing Near pkgs/development/python-modules/folium/default.nix:72:3: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: maintainers-missing Near pkgs/development/python-modules/google-cloud-bigquery/default.nix:135:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: maintainers-missing Near pkgs/development/python-modules/google-cloud-bigquery/default.nix:135:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: unused-argument warning: unused-argument warning: python-include-tests Near pkgs/development/python-modules/influxdb3-python/default.nix:50: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md warning: python-include-tests Near pkgs/development/python-modules/influxdb3-python/default.nix:50: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md warning: python-include-tests Near pkgs/development/python-modules/intake-parquet/default.nix:54: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md warning: python-include-tests Near pkgs/development/python-modules/intake-parquet/default.nix:54: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md warning: maintainers-missing Near pkgs/development/python-modules/streamz/default.nix:84:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: maintainers-missing Near pkgs/development/python-modules/streamz/default.nix:84:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: maintainers-missing Near pkgs/development/python-modules/tokenizers/default.nix:140:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: maintainers-missing Near pkgs/development/python-modules/tokenizers/default.nix:140:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md warning: unnecessary-parallel-building Near pkgs/development/gnuradio-modules/mkDerivation.nix:24:5: warning: unclear-gpl Near pkgs/servers/samba/4.x.nix:259:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md Near pkgs/servers/samba/4.x.nix:156:3: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md warning: environment-variables-go-to-env Near pkgs/build-support/rust/build-rust-package/default.nix:135:3: warning: unclear-gpl Near pkgs/applications/graphics/vpv/default.nix:60:5: See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md |
tobim
removed
the
10.rebuild-darwin: 101-500
Contributor
|
Can you please From 4163bfa593bfefe2d5b74b646bba638a9305f5b0 Mon Sep 17 00:00:00 2001
From: Tobias Mayer <tobim@fastmail.fm>
Date: Thu, 25 Jul 2024 22:04:41 +0200
Subject: [PATCH] thrift: fix cross
---
pkgs/by-name/th/thrift/package.nix | 24 +++++++++++-------------
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/pkgs/by-name/th/thrift/package.nix b/pkgs/by-name/th/thrift/package.nix
index 2686aa181b18..c638b6bd3d1e 100644
--- a/pkgs/by-name/th/thrift/package.nix
+++ b/pkgs/by-name/th/thrift/package.nix
@@ -9,6 +9,7 @@
, cmake
, pkg-config
, bison
+, pkgsBuildHost
, flex
, glibcLocales
, nix-update-script
@@ -27,6 +28,8 @@ stdenv.mkDerivation (finalAttrs: {
hash = "sha256-cwFTcaNHq8/JJcQxWSelwAGOLvZHoMmjGV3HBumgcWo=";
};
+ strictDeps = true;
+
# Workaround to make the Python wrapper not drop this package:
# pythonFull.buildEnv.override { extraLibs = [ thrift ]; }
pythonPath = [];
@@ -36,17 +39,15 @@ stdenv.mkDerivation (finalAttrs: {
cmake
flex
pkg-config
- python3
- python3.pkgs.setuptools
+ (python3.pythonOnBuildForHost.withPackages (ps: [
+ ps.setuptools
+ ps.tornado
+ ps.twisted
+ ]))
];
buildInputs = [
boost
- ] ++ lib.optionals (!static) [
- (python3.withPackages (ps: [
- ps.tornado
- ps.twisted
- ]))
];
propagatedBuildInputs = [
@@ -77,16 +78,13 @@ stdenv.mkDerivation (finalAttrs: {
cmakeFlags = [
(lib.cmakeBool "BUILD_JAVASCRIPT" false)
(lib.cmakeBool "BUILD_NODEJS" false)
-
- # FIXME: Fails to link in static mode with undefined reference to
- # `boost::unit_test::unit_test_main(bool (*)(), int, char**)'
- (lib.cmakeBool "BUILD_TESTING" (!static))
(lib.cmakeBool "WITH_STATIC_LIB" static)
+ (lib.cmakeBool "Boost_USE_STATIC_LIBS" static)
(lib.cmakeBool "OPENSSL_USE_STATIC_LIBS" static)
+ ] ++ lib.optionals (!stdenv.buildPlatform.canExecute stdenv.hostPlatform) [
+ "-DTHRIFT_COMPILER=${pkgsBuildHost.thrift}/bin/thrift"
];
- doCheck = !static;
-
nativeCheckInputs = [
glibcLocales
];
--
2.45.2
With the above change applied: Result of 32 packages marked as broken and skipped:
186 packages failed to build:
339 packages built:
Re-run with reduced 6 packages marked as broken and skipped:
14 packages failed to build:
104 packages built:
|
anthonyroussel
force-pushed
the
update-thrift
branch
from
360b082 to
cec2a9a
Compare
Member
Author
|
@tobim Thanks, I pushed your commit to fix cross compilation. |
Member
Author
|
Also had to run nixfmt-rfc-style on the pkgs/by-name/th/thrift/package.nix |
ofborg
Bot
added
the
10.rebuild-darwin: 101-500
wegank
added
the
2.status: merge conflict
13 tasks
nixpkgs-ci
Bot
added
the
2.status: stale
Member
|
FYI #374710 |
stale
Bot
removed
the
2.status: stale
Member
Author
|
Stall PR. See #374710 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.