thrift: fix python3 nativeBuildInputs#368304
Closed
tobim wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
🫤 |
github-actions
Bot
added
10.rebuild-darwin: 101-500
`python3.pkgs` appears to have issues with splicing. When building it in `pkgsCross`, or `pkgsStatic` the derivation uses the `hostPlatform` variant of `setuptools` as an input, but we want them for `buildPlatform` instead.
tobim
force-pushed
the
topic/thrift-workaround-splicing-issue
branch
from
4d2ff92 to
0fb387a
Compare
Contributor
Author
|
Better solution in #296770. |
github-actions
Bot
added
10.rebuild-darwin: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python3.pkgsappears to have issues with splicing. When building it inpkgsCross, orpkgsStaticthe derivation uses thehostPlatformvariant ofsetuptoolsas an input, but we want them forbuildPlatforminstead.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.