[Backport 2.15-maintenance] ci: Always run with sandbox, even on Darwin#8535
Merged
edolstra merged 4 commits intoJun 19, 2023
Merged
Conversation
And fix a test failure in the sandbox due to /home existing on Darwin but not being accessible in the sandbox since it's a symlink to /System/Volumes/Data/home, see https://github.com/NixOS/nix/actions/runs/4205378453/jobs/7297384658#step:6:2127: C++ exception with description "error: getting status of /home/schnitzel/darmstadt/pommes: Operation not permitted" thrown in the test body. On Linux this wasn't a problem because there /home doesn't exist in the sandbox (cherry picked from commit be48907)
This does pathExists on various paths, which crashes on EPERM in the macOS sandbox. (cherry picked from commit b7cde90)
(cherry picked from commit a6c78ba)
(cherry picked from commit 2c46248)
github-actions
Bot
added
the
with-tests
Member
Author
|
Thank you for the quick merge! May I ask what the ETA for cutting a maintenance release with this change is likely to be, as currently anyone using Home Manager on Darwin with the sandbox enabled gets a confusing error? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Despite the title of #8240, it fixes a regression caused by #8062 that broke running Nix inside sandboxed Nix builds on macOS. This leads to an obscure error activating Home Manager configurations due to the documentation generator, so I think backporting this is important (as 2.16 hasn't yet reached
pkgs.nixand 2.15 will be used on the stable branches for even longer). I've verified that the Home Manager documentation builds correctly after applying this PR.Fixes #8485.