Skip to content

Make nixd's noogle.dev code action workaround also work in case of invalid syntax #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JojOatXGME merged 1 commit into from
Jun 7, 2026
Merged

Make nixd's noogle.dev code action workaround also work in case of invalid syntax #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions src/main/java/org/nixos/idea/lsp/NixLspServerDescriptor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,20 +33,26 @@ internal class NixLspServerDescriptor(project: Project, private var settings: Ni

override val lspCustomization: LspCustomization = object : LspCustomization() {
override val codeActionsCustomizer = object : LspCodeActionsSupport() {
private fun getNoogleUrl(codeAction: CodeAction): String? =
(codeAction.data as? JsonObject)?.get("noogleUrl")?.asString

override fun createIntentionAction(lspServer: LspServer, codeAction: CodeAction): LspIntentionAction? {
if (getNoogleUrl(codeAction) != null) {
/* set an empty edit to prevent the IDE from calling
the LSP server and automatically opening the url */
codeAction.edit = WorkspaceEdit()
return object : LspIntentionAction(lspServer, codeAction) {
override fun invoke(project: Project, editor: Editor, psiFile: PsiFile) {
BrowserUtil.open(getNoogleUrl(codeAction)!!)
}
private fun handleOpenNoogleCodeAction(lspServer: LspServer, codeAction: CodeAction): LspIntentionAction? {
var noogleUrl = (codeAction.data as? JsonObject)?.get("noogleUrl")?.asString ?: return null
/* set an empty edit to prevent the IDE from calling
the LSP server and automatically opening the url */
codeAction.edit = WorkspaceEdit()
return object : LspIntentionAction(lspServer, codeAction) {
override fun invoke(project: Project, editor: Editor, psiFile: PsiFile) {
BrowserUtil.open(noogleUrl)
}
}
}

override fun createQuickFix(lspServer: LspServer, codeAction: CodeAction): LspIntentionAction? {
/* discard the "open Noogle" codeAction, or it will be shown twice */
handleOpenNoogleCodeAction(lspServer, codeAction)?.let {return null}
return super.createQuickFix(lspServer, codeAction)
}

override fun createIntentionAction(lspServer: LspServer, codeAction: CodeAction): LspIntentionAction? {
handleOpenNoogleCodeAction(lspServer, codeAction)?.let {return it}
return super.createIntentionAction(lspServer, codeAction)
}
}
Expand Down