Skip to content

Make nixd's noogle.dev code action workaround also work in case of invalid syntax#101

Merged
JojOatXGME merged 1 commit into
NixOS:masterfrom
Meallia:lsp-nixd-dont-open-noogle
Jun 7, 2026
Merged

Make nixd's noogle.dev code action workaround also work in case of invalid syntax#101
JojOatXGME merged 1 commit into
NixOS:masterfrom
Meallia:lsp-nixd-dont-open-noogle

Conversation

@Meallia

@Meallia Meallia commented May 31, 2026

Copy link
Copy Markdown
Contributor

Follow up to #100

The nixd noogle.dev workaround did not work in case of syntax errors in the nix file, in that case, the LSP client would also try to create a quickfix, resolve the original code action and open a new browser tab.

Applying the workaround in both createQuickFix and createIntentionAction made the "Open Noogle documentation" option appear twice. I tried disabling it in createQuickFix but it would also disable it in createIntentionAction, so I choose to discard it instead.

Tested with this (invalid) nix file

lib.getExe;

@JojOatXGME JojOatXGME merged commit e732182 into NixOS:master Jun 7, 2026
5 checks passed
@JojOatXGME

Copy link
Copy Markdown
Contributor

Thanks. I merged your changes. I will create a release with this fix in the next days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants