Make nixd's noogle.dev code action workaround also work in case of invalid syntax#101
Merged
Merged
Conversation
Contributor
|
Thanks. I merged your changes. I will create a release with this fix in the next days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #100
The nixd noogle.dev workaround did not work in case of syntax errors in the nix file, in that case, the LSP client would also try to create a quickfix, resolve the original code action and open a new browser tab.
Applying the workaround in both
createQuickFixandcreateIntentionActionmade the "Open Noogle documentation" option appear twice. I tried disabling it increateQuickFixbut it would also disable it increateIntentionAction, so I choose to discard it instead.Tested with this (invalid) nix file