Skip to content

Fix flaky testBypassSignalDependenciesWithBlocking by waiting for async notify #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikhiln64 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Fix flaky testBypassSignalDependenciesWithBlocking by waiting for async notify #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...engine/src/test/java/com/netflix/maestro/engine/dao/MaestroStepInstanceActionDaoTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,9 @@ public void testBypassSignalDependenciesWithBlocking() throws SQLException {

Thread.ofVirtual().start(() -> spyDao.bypassStepDependencies(instance, "job1", user, true));
verify(queueSystem, timeout(30000).times(1)).enqueue(any(), any(InstanceActionJobEvent.class));
verify(queueSystem, times(3)).notify(any());
// the action runs on a virtual thread, so the third notify can land after the enqueue
// verification above; wait for it instead of racing it
verify(queueSystem, timeout(30000).times(3)).notify(any());
// assert that the action was saved
Assert.assertTrue(actionDao.tryGetAction(summary, "job1").isPresent());
Assert.assertEquals(
Expand Down