Fix flaky testBypassSignalDependenciesWithBlocking by waiting for async notify - #227
Open
nikhiln64 wants to merge 1 commit into
Open
Fix flaky testBypassSignalDependenciesWithBlocking by waiting for async notify#227nikhiln64 wants to merge 1 commit into
nikhiln64 wants to merge 1 commit into
Conversation
nikhiln64
force-pushed
the
fix/flaky-bypass-dependencies-test
branch
from
July 14, 2026 14:01
bf6a36c to
128e68b
Compare
nikhiln64
force-pushed
the
fix/flaky-bypass-dependencies-test
branch
from
July 21, 2026 19:33
128e68b to
dd37238
Compare
…nc notify The bypass action runs on a virtual thread. The enqueue verification waits with timeout(30000), but the following notify verification had no timeout, so it raced the third notify call and intermittently failed with TooFewActualInvocations (wanted 3, got 2). Use the same timeout-based verification as the surrounding assertions.
nikhiln64
force-pushed
the
fix/flaky-bypass-dependencies-test
branch
from
July 21, 2026 20:25
dd37238 to
70720fe
Compare
Author
|
@jun-he when you get a moment, the CI run for this one is waiting for maintainer approval to start. It is a small deterministic fix for a flaky test race and the branch is current with main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew build --write-locksto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Fixes an intermittent failure in
MaestroStepInstanceActionDaoTest.testBypassSignalDependenciesWithBlocking.The bypass action runs on a virtual thread. The
enqueueverification waits withtimeout(30000), but thenotifyverification immediately after it had no timeout, so it raced the thirdnotifycall from the async thread and intermittently failed withTooFewActualInvocations(wanted 3, got 2) - typically under load during a full./gradlew build, while passing in isolation.The fix uses the same timeout-based verification as the surrounding assertions in this test, so the intent is unchanged and the assertion simply waits for the async work instead of racing it.
Verified:
./gradlew :maestro-engine:test --tests MaestroStepInstanceActionDaoTestgreen on 3 consecutive reruns;spotlessApplyrun as per the template.