Rjf/gtfs final fixes#159
Merged
Merged
Conversation
added 16 commits
July 2, 2026 11:09
…or mode-specific filter settings
… in no_aggregate_opportunities helper function
robfitzgerald
marked this pull request as ready for review
July 13, 2026 14:43
Collaborator
Author
|
@admrtin this PR is ready for review. as in #158 i think my main goal for a review is for you to run the test described above. there's a note describing additional fixes. i haven't gone so far as to create new tests of the code changes and i'm ok with that choice for the most part, except for maybe the code that had the out-of-index error fixes. let me know what you think. |
admrtin
reviewed
Jul 13, 2026
admrtin
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

this PR contains the final set of fixes applied while working toward a successful run of BAMBAM for GTFS-Flex access modeling, which includes the change set from #158 which was cancelled after discovering it was missing a required fix present in this PR.
GTFS-Flex run fixes
negatekey on destination filter optional for simplicitystate_model.contains_keyand provide error context in multimodal_traversal_opssimplify OMF Places mapping
these mappings can be quite long - there are over 2000 OvertureMaps categories total - and so expressing that directly within a bambam config file is noisy. this PR allows the user to alternatively define a CSV source for category mapping:
testing
omf-csv-test-assets.zip