Rjf/omf csv mapping source#158
Closed
robfitzgerald wants to merge 3 commits into
Closed
Conversation
Collaborator
|
@robfitzgerald after copying the files into my repo, checking out this branch, and running the build command and bambam command, I received the following error: The error message comes from the |
admrtin
requested changes
Jul 9, 2026
Collaborator
Author
|
these code changes appear as part of PR #159. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR introduces an alternative means to load an OvertureMaps Places mapping. these mappings can be quite long - there are over 2000 OvertureMaps categories total - and so expressing that directly within a bambam config file is noisy. this PR allows the user to alternatively define a CSV source for category mapping:
testing
omf-csv-test-assets.zip