-
Notifications
You must be signed in to change notification settings - Fork 40
docs: document automatic skill-load marks [3/3] #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -128,6 +128,9 @@ The generated Hermes hooks cover `on_session_start`, `on_session_end`, | |
| `pre_api_request`, `post_api_request`, `api_request_error`, `pre_tool_call`, | ||
| `post_tool_call`, `subagent_start`, and `subagent_stop`. | ||
|
|
||
| Hermes `skill_view` pre-tool calls emit observed `skill.load` marks. The mark | ||
| contains only the skill name and tool identity; it does not retain skill paths. | ||
|
Comment on lines
+131
to
+132
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win Distinguish the payload from the complete mark metadata. The canonical mark contains only 🤖 Prompt for AI Agents |
||
|
|
||
| The API hooks are the main Hermes LLM lifecycle path for NeMo Relay. The legacy | ||
| LLM hooks remain installed because they can still provide useful private hints, | ||
| but they are not treated as equal peers to the API hooks in the observability | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Make the “exact” event example include its envelope fields.
The implementation also sets
parent_uuidandtimestampon each mark, but the example omits them while presenting itself as the complete observed shape. Either include those fields with their serialized types or label this example as the payload-only shape.🤖 Prompt for AI Agents