docs: document automatic skill-load marks [3/3]#393
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
Signed-off-by: Will Killian <wkillian@nvidia.com>
Signed-off-by: Will Killian <wkillian@nvidia.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (34)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
License DiffCompared against Lockfile license changesLockfile License ChangesRustAdded
Removed
Updated/Changed
NodeAdded
Removed
Updated/Changed
PythonAdded
Removed
Updated/Changed
Status output |
| | `before_message_write` | Records assistant turns for ordered LLM replay when provider timing can be paired later. | | ||
| | `after_tool_call` | Replays successful tool calls as tool spans; blocked tools emit marks. | | ||
| | `before_tool_call` | Runs conditional guardrails and eagerly starts stable-ID skill-read spans before default argument stripping. | | ||
| | `after_tool_call` | Completes successful tool spans; blocked tools emit marks. When no stable pre-tool call is available, original parameters provide the skill-load fallback. | |
There was a problem hiding this comment.
This wording currently over-claims the stack behavior. In 392, the eager skill-read path returns before blockedToolDetails() runs, so an eager read_file that comes back blocked can close the tool span without emitting the existing openclaw.tool_blocked mark. I’d either preserve that mark path in code or narrow this doc to match the implementation.
mnajafian-nv
left a comment
There was a problem hiding this comment.
Great work on documenting the skill-load contract across the host and integration surfaces. One docs consistency gap remains outside this diff: docs/nemo-relay-cli/basic-usage.mdx still lists the Claude Code and Codex hook bundles only through PreCompact, while this PR adds UserPromptExpansion to the host-specific docs. That leaves readers with conflicting answers depending on which page they open first. I’d update the top-level hook matrix in the same stack, or explicitly call out the follow-up if it is being deferred.
Overview
Documents RELAY-443 automatic skill-load marks across coding agents, framework integrations, exporters, and observability guidance. This is the third commit in a three-PR cumulative stack; all three PRs target upstream
mainas requested, so this PR temporarily includes the first two commits until they merge.Details
Validation:
just docs, documentation link checks, anduv run pre-commit run --all-files.Breaking changes: none.
Where should the reviewer start?
Start with
docs/about-nemo-relay/concepts/events.mdx, then review the host-specific CLI and integration pages.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)