Fix Phase 2 Excel identity and shared column-mapping heuristics#25
Merged
Conversation
- Prefer ID for remove/modify/add upserts; fail closed on ambiguous NAME matches - Surface estimated affected DB rows (and ambiguous names) in the import UI - Deduplicate column-mapping synonyms into utils; prompt fallback reuses them Co-authored-by: Mukesh Vemulapalli <vemulapallimukesh@gmail.com>
Mukku27
marked this pull request as ready for review
July 10, 2026 12:06
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements PR B / Phase 2 of the bug-fix plan: safer Excel row identity and a single column-mapping heuristic source.
Changes
remove/modify/ add-upsert preferIDwhen present; NAME-only destructive actions that match multiple rows raiseAmbiguousProductMatchError(fail closed).estimate_import_impact()reports file rows, matched DB rows, and ambiguous names; the Streamlit upload UI surfaces these before approval.COLUMN_MAPPING_SYNONYMS+_heuristic_column_mappinginutils.pyare the single source;prompt._fallback_column_mappingdelegates to them (alias tokens also match spaced names likeProduct Name→NAME).Tests
ruff checkclean on touched filespytest: 82 passedOut of scope (Phase 3)
ensure_schema