Fix Phase 3 startup schema migration and audit log rotation#26
Merged
Conversation
- Call ensure_schema before validate on app startup; hint when PRODUCT is empty - Rotate ai_operation_audit.jsonl at 100 MB, keeping the newest 3 archives Co-authored-by: Mukesh Vemulapalli <vemulapallimukesh@gmail.com>
Mukku27
marked this pull request as ready for review
July 10, 2026 12:13
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements PR C / Phase 3 of the bug-fix plan: migrate schema on app startup and rotate oversized audit logs.
Changes
app.pycallsensure_schema(db_path)beforevalidate_product_schema(db_path), so a fresh clone no longer requires a separate migrate step before launch.PRODUCThas 0 rows, the UI shows anst.infopointing topython database.py --seed(seeding remains opt-in).ai_operation_audit.jsonlreaches 100 MB, it is rotated to.1/.2/.3(newest 3 archives kept) before the next event is written; emits aUserWarningon rotation.Tests
tests/test_audit.pyruff checkclean on touched filespytest: 85 passedCompletes the bug-fix plan
Phases 1–3 (PRs #24, #25, and this PR) cover the prioritized correctness bugs from the action plan.