Fix Phase 1 AI bugs: Gemini model, analytics fallback, SQL extraction#24
Merged
Conversation
…traction - Default to gemini-3.5-flash via shared config.DEFAULT_GEMINI_MODEL - Analytics returns deterministic summaries when AI is unavailable and audits results - Extract SQL from markdown fences; fall back using the user question - NL→SQL prompts include the full PRODUCT schema description Co-authored-by: Mukesh Vemulapalli <vemulapallimukesh@gmail.com>
Mukku27
marked this pull request as ready for review
July 10, 2026 11:54
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements PR A / Phase 1 of the bug-fix plan: unblock the AI path and fix silent SQL/schema prompt failures.
Changes
config.DEFAULT_GEMINI_MODELdefaults togemini-3.5-flash(override withGEMINI_MODEL_NAME). Replaces shut-downgemini-1.5-flashin analytics and SQL generation.analytics_*)._extract_sql()handles markdown fences and prose wrappers so fenced Gemini output is not discarded for keyword fallback. SQL fallback uses the original question, not the full prompt template.get_product_schema_description()builds prompts from live/PRODUCT_REQUIRED_COLUMNS(includes BRAND, SIZE, COLOR, WEIGHT, SPECIFICATIONS).Tests
ruff checkclean on touched filespytest: 77 passedOut of scope (later PRs)
ensure_schema, audit rotation (Phase 3)