Skip to content

Add PR build workflow #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ncipollina merged 2 commits into from
Jul 17, 2026
Merged

Add PR build workflow #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e94d6b3
Add PR build workflow via devops-templates reusable pipeline
ncipollina Jul 17, 2026
6b5ddbb
Fix PR Build startup failure: match required reusable-workflow permis…
ncipollina Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/pr-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: PR Build

on:
pull_request:
Comment thread
ncipollina marked this conversation as resolved.
branches:
- main
workflow_dispatch:
permissions:
id-token: write
contents: write
pull-requests: write
jobs:
build:
uses: LayeredCraft/devops-templates/.github/workflows/pr-build.yaml@v10.1
with:
solution: "SharpMud.slnx"
hasTests: true
useMtpRunner: true
runCdk: false
dotnetVersion: "11.0.x"
20 changes: 18 additions & 2 deletions docs/deployment.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,20 @@ image → data still there test.
ASCII/English, so invariant globalization mode avoids needing the larger
`-extra` image variant for culture data nothing uses.

## Continuous Integration

`.github/workflows/pr-build.yaml` runs on every PR against `main`
(`workflow_dispatch` also available for a manual run) — restores, builds,
and runs the full test suite (`SharpMud.slnx`, `hasTests: true`,
`useMtpRunner: true` to match this repo's xUnit v3 + Microsoft Testing
Platform setup, per `testing.md`). It's a thin caller into
[`LayeredCraft/devops-templates`](https://github.com/LayeredCraft/devops-templates)'s
reusable `pr-build.yaml`, the same pattern other LayeredCraft repos use —
not a bespoke pipeline. `runCdk: false` since this repo deploys as a plain
Docker image (see Container above), not AWS CDK/Lambda; the reusable
workflow's CDK/Lambda-function inputs and secrets are simply unused here.
No image build/publish step yet — see Open Items.

## Verified

Built and run locally via Docker: image builds clean (no warnings), the
Expand Down Expand Up @@ -88,8 +102,10 @@ wouldn't stop cleanly before the fix.
check yet beyond "process is running."
- Multi-arch image builds (arm64 + amd64) — currently only built for the
local dev machine's architecture.
- CI-driven image builds/publishing — no pipeline exists yet; images are
built manually.
- ~~CI-driven build/test~~ — resolved, see Continuous Integration above.
Still open: CI-driven **image** builds/publishing — the PR workflow only
builds/tests the .NET solution, it doesn't build or push the Docker
image; that's still done manually.
- No documentation/tooling yet for backing up the `/data` volume itself —
the volume mount solves "survives a redeploy," not "survives host disk
loss."
Loading