Add PR build workflow#3
Merged
Merged
Conversation
Restores/builds/tests SharpMud.slnx on every PR against main, using this repo's xUnit v3 + Microsoft Testing Platform setup (useMtpRunner: true). runCdk: false since this repo deploys as a plain Docker image (see deployment.md), not AWS CDK/Lambda - the reusable workflow's CDK/Lambda inputs and secrets are simply unused. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e94d6b3293
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…sions The reusable pr-build.yaml declares id-token/contents/pull-requests write at the workflow level; GitHub validates a caller's granted permissions against that before any job starts, so trimming this down to contents: read (since runCdk: false means those scopes go unused at runtime) caused a zero-job startup_failure - the check happens at dispatch time regardless of which code paths actually run. Matching trivia-manager's known-working permissions block instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/pr-build.yaml, a thin caller intoLayeredCraft/devops-templates's reusablepr-build.yaml@v10.1(same pattern as other LayeredCraft repos, e.g. trivia-manager).SharpMud.slnx) on every PR againstmain, plusworkflow_dispatchfor a manual run.useMtpRunner: trueto match this repo's xUnit v3 + Microsoft Testing Platform setup.runCdk: false— this repo deploys as a plain Docker image (seedocs/deployment.md), not AWS CDK/Lambda, so the reusable workflow's CDK/Lambda-function inputs and secrets are unused/omitted entirely.docs/deployment.md: new "Continuous Integration" section, and closes the "CI-driven build/test" half of the existing Open Item (image build/publish is still manual and still open).Treated as adopting an existing org-wide tooling convention rather than a from-scratch architecture decision, so no ADR — flagging that judgment call here in case it should have one.
Test plan
🤖 Generated with Claude Code