Skip to content

Fix: Board card never actually hid (CSS specificity beat [hidden]) #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kyzcreig merged 1 commit into from
Jul 21, 2026
Merged

Fix: Board card never actually hid (CSS specificity beat [hidden]) #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions app/static/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@
box-sizing: border-box;
}

/* The `hidden` attribute must always win — class rules like `.metric { display: flex }`
otherwise beat the UA `[hidden]` default (specificity 0,1,0 vs 0,0,0), leaving
data-optional cards (e.g. Board when Redfish reports no temp) stuck visible. */
[hidden] {
display: none !important;
}

html,
body {
width: 100%;
Expand Down
10 changes: 10 additions & 0 deletions tests/test_ui_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,16 @@ def test_mobile_css_prevents_390px_horizontal_overflow():
assert "minmax(0, 1fr)" in css


def test_hidden_attribute_beats_class_display_rules():
# data-optional cards (e.g. Board when Redfish has no temp) set hidden=true in JS;
# without this rule .metric{display:flex} wins on specificity and the card stays
# visible. Regression guard for the live bug where Board showed a dead --deg.
css = read("app/static/style.css")

assert "[hidden]" in css
assert "display: none !important" in css


def test_dashboard_formats_missing_values_and_machine_reasons_for_people():
javascript = read("app/static/js/dashboard.js")

Expand Down
Loading